Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed ToVariant/FromVariant derive for generic types with bounds #961

Merged
merged 1 commit into from
Oct 16, 2022
Merged

Fixed ToVariant/FromVariant derive for generic types with bounds #961

merged 1 commit into from
Oct 16, 2022

Conversation

Bromeon
Copy link
Member

@Bromeon Bromeon commented Oct 12, 2022 •
edited
Loading

Fixes part of #957; but there's a separate problem with where clauses (see description).

@Bromeon
Fixed ToVariant/FromVariant derive for generic types with bounds
ea43b63 
Example:
   enum MyEnum<T: Bound>

was expanded to:
   impl<T: Bound> ToVariant for MyEnum<T: Bound>

instead of:
   impl<T: Bound> ToVariant for MyEnum<T>
@Bromeon Bromeon added bug c: export Component: export (mod export, derive) labels Oct 12, 2022
@Bromeon Bromeon added this to the v0.11.x milestone Oct 12, 2022
bors bot added a commit that referenced this pull request Oct 12, 2022
@bors
Try #961:
fad8a1e
@bors
Copy link
Contributor

bors bot commented Oct 12, 2022

try

Build succeeded:

@Bromeon
Copy link
Member Author

Bromeon commented Oct 12, 2022

bors try

bors bot added a commit that referenced this pull request Oct 12, 2022
@bors
Try #961:
dde79a6
@bors
Copy link
Contributor

bors bot commented Oct 12, 2022

try

Build failed:

@Bromeon
Copy link
Member Author

Bromeon commented Oct 12, 2022

Great, clippy stable conflicts with clippy nightly. Real good experience there 🙄
clippy nightly causes so much extra maintenance effort that I'm seriously thinking of ditching that CI job...

I'll revert the 2nd commit.

@Bromeon Bromeon force-pushed the bugfix/to-variant-bounds branch from 2d5bf2e to ea43b63 Compare October 12, 2022 21:12
@Bromeon
Copy link
Member Author

Bromeon commented Oct 12, 2022

bors try

bors bot added a commit that referenced this pull request Oct 12, 2022
@bors
Try #961:
adaa2b5
@Bromeon Bromeon mentioned this pull request Oct 12, 2022
Open
@bors
Copy link
Contributor

bors bot commented Oct 12, 2022

try

Build succeeded:

@Bromeon
Copy link
Member Author

Bromeon commented Oct 16, 2022

I'll merge this so the remaining problems (where clause) can be fixed in a separate PR.

bors r+

@bors
Copy link
Contributor

bors bot commented Oct 16, 2022

Build succeeded:

@bors bors bot merged commit 20d8604 into godot-rust:master Oct 16, 2022
@Bromeon Bromeon deleted the bugfix/to-variant-bounds branch October 16, 2022 08:27
@chitoyuu chitoyuu modified the milestones: v0.11.x, v0.11.1 Dec 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug c: export Component: export (mod export, derive)
Projects
None yet
Milestone
v0.11.1
Development

Successfully merging this pull request may close these issues.
2 participants
@Bromeon @chitoyuu