Fix quotation for timestamps #515
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shuheiktgw
commented
Nov 9, 2024
| @@ -600,20 +601,23 @@ func ToNumber(value string) *NumberValue { | |||
| } | |||
| } | |||
|
|
|||
| func looksLikeTimeValue(value string) bool { | |||
There was a problem hiding this comment.
I've combine it into the isTimestamp function
shuheiktgw
force-pushed
the
fix_timestamp_quotation
branch
from
cbf7fef to
7a77092
Compare
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #515 +/- ##
==========================================
+ Coverage 79.09% 79.12% +0.02%
==========================================
Files 17 17
Lines 6110 6104 -6
==========================================
- Hits 4833 4830 -3
+ Misses 965 963 -2
+ Partials 312 311 -1 |
goccy
reviewed
Nov 10, 2024
| continue | ||
| // This is a subset of the formats permitted by the regular expression | ||
| // defined at http://yaml.org/type/timestamp.html. Note that time.Parse | ||
| // cannot handle: "2001-12-14 21:59:43.10 -5" from the examples. |
There was a problem hiding this comment.
Why didn't you provide a layout to handle this case ?
There was a problem hiding this comment.
Yes I've actually tried supporting the layout, but Go does not seem to support the "-timezone" representation...
|
LGTM 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #430
Before submitting your PR, please confirm the following.