ci: fix go tool usage on Windows

go-simpler · Mar 11, 2023 · 385aa6c · 385aa6c
1 parent 20620e1
commit 385aa6c
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 4 deletions.
diff --git a/.github/workflows/go.yml b/.github/workflows/go.yml
@@ -23,7 +23,9 @@ jobs:
           go-version: ${{ matrix.go }}
 
       - name: Run tests
-        run: go test -race -shuffle=on -coverprofile=coverage.out ./...
+        # do not use `=` to join flags and values, it won't work on Windows;
+        # see https://github.com/PowerShell/PowerShell/issues/6291 for details.
+        run: go test -v -race -shuffle on -coverprofile coverage.out ./...
 
       - name: Upload coverage
         uses: codecov/codecov-action@v3

diff --git a/musttag_test.go b/musttag_test.go
@@ -12,9 +12,9 @@ import (
 )
 
 func TestAnalyzer(t *testing.T) {
-	// NOTE(junk1tm): analysistest does not yet support modules
-	// (see https://github.com/golang/go/issues/37054 for details).
-	// So, to be able to run tests with external dependencies,
+	// NOTE(junk1tm): analysistest does not yet support modules;
+	// see https://github.com/golang/go/issues/37054 for details.
+	// To be able to run tests with external dependencies,
 	// we first need to write a GOPATH-like tree of stubs.
 	prepareTestFiles(t)
 	testPackages = []string{"tests", "builtins"}