Added redis tag for redis key prefix to fix CROSSSLOT error in redis … #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cluster. Added curly braces around the key prefix name makes it a redis-tag. redis-tag ensures that all the keys starting with this prefix are mapped to the same keyslot when redis which will fix CROSSSLOT error in redis cluster.In single instance mode all keyslots are present in same shard hence CROSSSLOT error will not happen.
|
Please review and close this PR asap. We are actually looking for this fix in the code because in a cluster env , if there is no redis -tag used then the keys get distributed among multiple shards which breaks the counting. This fix will ensure that all the keys are mapped to same shards even in cluster env. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…cluster.
Added curly braces around the key prefix name makes it a redis-tag. redis-tag ensures that all the keys starting with this prefix are mapped to the same keyslot when redis which will fix CROSSSLOT error in redis cluster.In single instance mode all keyslots are present in same shard hence CROSSSLOT error will not happen.