-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates for Go 1.17 #7
Conversation
@peterbourgon ping. |
Should we tag this change, so we can make the ones in the kit repo? |
@sagikazarmark Can you clarify? I see this as part of the next milestone... |
This package still has a dependency on |
@peterbourgon My understanding is that tagging the log package blocks advancing to the Go 1.17 change in the kit repo. At least that was my assumption based on Chris's first comment. @ChrisHines let me take a look at dropping the stack dependency. |
It's not so much blocking the Go 1.17 change in the kit repo, but without it some the module graph pruning behavior of Go 1.17 would not apply to the log package. So the optimal sequence is to tag |
I think we are ready for that, aren't we? I managed to get rid of the stack package. |
I saw your PR. I'll review it later when I have a block of time. I expect to make a couple of comments to see if we can simplify. |
We can tag a new release, sure. Does the bump to 1.17 warrant 0.2.0 or can we get away with 0.1.1? |
@ChrisHines it's already merged, but I'm happy to followup. @peterbourgon My default answer would be 0.2.0, but I have no strong opinion on the matter. |
@sagikazarmark Ahh, in that case I might tinker with it on my own tonight and see if I find any improvements. In any case, thanks for making the change. :) Regarding version. I did a patch bump on some other packages, but only the |
I'll do that in a couple hours unless there's an objection. Should it be immediately followed by any action in kit? |
No objection. Chris's followup PR was also merged, so I think we are good. The next action in kit would be updating the log module in go-kit/kit#1105 and finishing up the PR for merging. |
Yep, we should be good to tag this repo. |
I want to update this package and tag a patch release before updating
go-kit/kit
in go-kit/kit#1105. I've already updated both of this package's dependencies along the same lines. Just working my way up the tree to minimize the number of new releases and maximize the benefit of the Go 1.17 module pruning feature for consumers.