transport/http: NewExplicitClient #971
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LasTshaMAN
approved these changes
Mar 20, 2020
Comment on lines
+20
to
+24
| // CreateRequestFunc creates an outgoing HTTP request based on the passed | ||
| // request object. It's designed to be used in HTTP clients, for client-side | ||
| // endpoints. It's a more powerful version of EncodeRequestFunc, and can be used | ||
| // if more fine-grained control of the HTTP request is required. | ||
| type CreateRequestFunc func(context.Context, interface{}) (*http.Request, error) |
There was a problem hiding this comment.
Don't you want to mark EncodeRequestFunc as // deprecated linking this issue for more information ?
There was a problem hiding this comment.
No, because I don't consider it deprecated, this is just an alternative.
Comment on lines
+202
to
+206
| // | ||
| // | ||
| // | ||
|
|
||
| func makeCreateRequestFunc(method string, target *url.URL, enc EncodeRequestFunc) CreateRequestFunc { |
There was a problem hiding this comment.
Maybe add some meaningful comments here instead ? :)
There was a problem hiding this comment.
It's an unexported function, and I find it pretty self-explanatory.
|
Cool, thanks! |
This was referenced Oct 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #796, alternative to #916.