Handle JSON RPC errors. Resolves issue #672. #673
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterbourgon
approved these changes
Mar 12, 2018
| // DecodeResponseFunc extracts a user-domain response object from an HTTP | ||
| // request object. It's designed to be used in JSON RPC clients, for | ||
| // DecodeResponseFunc extracts a user-domain response object from an JSONRPC | ||
| // response object. It's designed to be used in JSON RPC clients, for | ||
| // client-side endpoints. One straightforward DecodeRequestFunc could be |
There was a problem hiding this comment.
Oops, looks like a copy/paste flub in the comment! Probably there are others of these, too. Also, does the actual comment from this point on make sense?
There was a problem hiding this comment.
Thanks for spotting that. I've made some tweaks to the doc comments in that file.
|
I think this looks tidy now. I'll be using it in anger in the near future, so will feed back if there are any other tweaks needed. |
|
@peterbourgon before merge I'd like to play a bit with it... can you wait max. a day until merge? |
|
@basvanbeek I'll wait until you ping me again 👍 |
|
Failures are related to the Thrift nonsense, so I'm gonna optimistically merge. |
jamesgist
pushed a commit
to jamesgist/kit
that referenced
this pull request
Nov 1, 2024
* Handle JSON RPC errors. Resolves issue go-kit#672. * Refactor decode func to receive JSON RPC response. Remove error func. * Comment tweaks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.