Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go.mod | go.sum: update dependencies for prometheus client_golang #1225

Merged
merged 3 commits into from
Apr 23, 2022

Conversation

vcruzmj
Copy link
Contributor

@vcruzmj vcruzmj commented Apr 21, 2022

Update dependency for vulnerability on https://nvd.nist.gov/vuln/detail/CVE-2022-21698
Issue: #1224

@ChrisHines
Copy link
Member

What version of Go and what commands did you use to create this PR? The changes here seem too extensive for upgrading one module. I am especially surprised to see some modules move to older versions.

I seem to get much more modest changes with Go 1.18 and these commands:

$ go get github.com/prometheus/[email protected]
$ go mod tidy

@vcruzmj
Copy link
Contributor Author

vcruzmj commented Apr 23, 2022

Sorry, rookie mistake, I mess up with the github.com/prometheus/common indirect dependency, but that change is unnecessary and invasive, and your approach solve the vulnerability. I just commit that.

@ChrisHines
Copy link
Member

OK. Thanks for the updates.

I'm kicking off the builds.

@ChrisHines ChrisHines merged commit d7cefca into go-kit:master Apr 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants