Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cloudwatch metrics does not limit nr. of MetricDatums to 20 per call #529

Closed
feliksik opened this issue May 15, 2017 · 7 comments
Closed

Comments

@feliksik
Copy link
Contributor

According to the AWS Docs, a max of 20 metricdatums can be sent in an API request.

So this code should respect that.

I might get to fixing this myself, but not today...

@cam-stitt
Copy link
Contributor

Good find. Thanks for this.

@alpeb
Copy link
Contributor

alpeb commented May 23, 2017

Would it suffice if I add checks for that in NewCounter, NewGauge and NewHistogram that would panic if that limit is reached?

@cam-stitt
Copy link
Contributor

I'm not sure if a panic would be ideal in this situation. We should be able to split it into a max of 20 datums and spread it to multiple api requests.

@alpeb
Copy link
Contributor

alpeb commented May 24, 2017

Sounds good. Can I have the honor of submitting a PR for this, or you prefer to tackle it yourself? :)
I was thinking we could do it in batches of concurrent API requests, say up to 4 concurrent requests per batch. Let me know what you think.

@cam-stitt
Copy link
Contributor

Go for it! Happy to share. I would suggest making an option NumConcurrentRequests to specify how many requests can be sent per batch.

peterbourgon added a commit that referenced this issue Jul 4, 2017
Issue #529: Partition API requests to CloudWatch into separate concur…
@cam-stitt
Copy link
Contributor

@peterbourgon I believe we can probably close this off now?

@peterbourgon
Copy link
Member

Jawohl.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants