Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ini: allow changing the default section name #319

Merged
merged 1 commit into from
Aug 8, 2022

Conversation

jade-clarke
Copy link
Contributor

@jade-clarke jade-clarke commented Apr 17, 2022

Describe the pull request

Changed the DefaultSection constant to a variable so that it may be altered for use with AWS cli configs.

Link to the issue: #287

Checklist

  • I agree to follow the Code of Conduct by submitting this pull request.
  • I have read and acknowledge the Contributing guide.
  • I have added test cases to cover the new code.

Copy link
Member

@unknwon unknwon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@unknwon unknwon changed the title Changed the DefaultSection constant to a variable. ini: allow changing the default section name Apr 26, 2022
@unknwon
Copy link
Member

unknwon commented Apr 26, 2022

CI did not pass, and because I can't edit the branch directly, looks like you would have to apply the fix in this commit to make CI pass.

@jade-clarke jade-clarke force-pushed the aws-cli-compatibility-fix branch from b8f2098 to 3493201 Compare June 30, 2022 22:44
@jade-clarke
Copy link
Contributor Author

I updated the deprecated.go file

@unknwon
Copy link
Member

unknwon commented Aug 8, 2022

Thanks for the followup, merging!

@unknwon unknwon merged commit b2f570e into go-ini:main Aug 8, 2022
@unknwon
Copy link
Member

unknwon commented Aug 8, 2022

https://github.com/go-ini/ini/releases/tag/v1.67.0 has been tagged for the merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants