Implement basic Open Graph support. #901
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lunny
requested changes
Feb 11, 2017
| @@ -252,6 +252,11 @@ func (u *User) HomeLink() string { | |||
| return setting.AppSubURL + "/" + u.Name | |||
| } | |||
|
|
|||
| // HTMLURL returns the user or organization's full link. | |||
| func (u *User) HTMLURL() string { | |||
| return setting.AppURL + u.Name | |||
There was a problem hiding this comment.
HomeLink() returns a relative URL, and Open Graph demands a canonical URL.
lunny
added
the
type/feature
lunny
approved these changes
Feb 11, 2017
|
LGTM |
tboerger
added
the
lgtm/need 1
appleboy
approved these changes
Feb 11, 2017
|
LGTM Nice feature. |
tboerger
added
lgtm/done
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for the Open Graph protocol.