feat: Add search bar on user profile page. #787
Conversation
lunny
added
the
type/feature
|
LGTM |
tboerger
added
the
lgtm/need 1
|
conflicted |
|
@lunny Done. |
| } | ||
|
|
||
| ctx.Data["Repos"] = repos | ||
| ctx.Data["Page"] = paginater.New(int(count), setting.UI.User.RepoPagingNum, page, 5) |
There was a problem hiding this comment.
$ go doc github.com/Unknwon/paginater.New
func New(total, pagingNum, current, numPages int) *Paginater
New initialize a new pagination calculation and returns a Paginater as
result.
What's the meaning of numPages ? How's that different from total/pagingNum ?
@unknwon ? Maybe the documentation on that could be improved
There was a problem hiding this comment.
From the README.md of the paginater:
// Arguments:
// - Total number of rows
// - Number of rows in one page
// - Current page number
// - Number of page links
p := paginater.New(45, 10, 3, 3)
I still don't understand what Number of page links means though.
Is it the expected number of pages ? As that could be computed as ceil(Total number of rows / Number of rows in one page), right ?
There was a problem hiding this comment.
Ok I think I got it: it's the number of page links you want to be visible in a template. Sounds a bit wrong to mix output control and flow control to me, but this is not the place to discuss this. Still maybe it's good to have a configuration in settings about the number of pager links ? As I see that hard-coded 5 in many places even only in this file...
There was a problem hiding this comment.
@strk I think this may be a bug. I change the Number of page links to 2. It still show five items in a template.
|
LGTM, even :) |
tboerger
added
lgtm/done
|
let L-G-T-M work |
Screenshot as below: