-
-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Website binding MaxSize to 255 #722
Conversation
LGTM |
if 100 is enough for a URL? |
http://stackoverflow.com/questions/417142/what-is-the-maximum-length-of-a-url-in-different-browsers I usually make the URL length as |
100 seems to be the Gitea default, but we could change them to 255. |
My current use case is less than 100, so as long as I can use that I am fine. However, I would suggest setting the limit to urls to 2047 since that seems to be the maximum that search engines will crawl according to the SO article posted earlier |
Make sure that the db column is set to 255 and do the same here |
I've updated all website binding MaxSize to 255 |
LGTM |
Not changed the XORM struct? |
Default is 255? Since I can't find |
Yes, default is 255. |
Fixes #713