-
-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrate public as bindata optionally #293
Conversation
I thought this was a huge PR, but then I saw all the LGTM |
LGTM |
Which package is pulling in BoltDB and EtcD? o.O |
I think boltdb is a missing dependency for tidb, etcd I have not checked. |
Why put go files in |
Then we should also move all assets into another subfolder |
Why? And another thing, now all the golint pass except |
Because of package name |
So what's up with it now? I would build the other bindata changes based on that. |
Ha, I will try to move the .go files to modules. |
I have moved the bindata now into modules/public/ and updated the web cmd as well. This should be fine now, including optional bindata. |
LGTM :) |
Since there have been people crying because of the big bindata PR I'm trying to split it into multiple smaller pull requests. This is the first step which embeds the public folder optionally into the binary with the build tag
bindata
. This pull requests obsoletes parts of #74.