Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Commits and pull files #124

Closed
1 of 2 tasks
lunny opened this issue Nov 9, 2016 · 33 comments · Fixed by #3748
Closed
1 of 2 tasks

Commits and pull files #124

lunny opened this issue Nov 9, 2016 · 33 comments · Fixed by #3748
Labels
type/feature Completely new functionality. Can only be merged if feature freeze is not active. type/proposal The new feature has not been accepted yet but needs to be discussed first.
Milestone
1.6.0

Comments

@lunny
Copy link
Member

lunny commented Nov 9, 2016 •
edited
Loading

Before we can start a review, we can implement comment on one line of PRs at first.
I think this includes two sub issues.
@lunny lunny added type/proposal The new feature has not been accepted yet but needs to be discussed first. type/feature Completely new functionality. Can only be merged if feature freeze is not active. labels Nov 9, 2016
@lunny lunny added this to the 1.1.0 milestone Nov 9, 2016
@bkcsoft
Copy link
Member

bkcsoft commented Nov 9, 2016 •
edited
Loading

well, If we implement comments on commits we should get this "for free" 🙂

@metalmatze
Copy link
Contributor

I'm not sure. I don't know the internals, but the comment may go onto a commit page. Then you can discuss this commit.
But this issue targets a bigger picture. A PR might have multiple commits and those can change over time. So I agree that comments on commits might benefit comments on PR with some work already done nevertheless I feel that there's more to it.

@lunny
Copy link
Member Author

lunny commented Nov 10, 2016

Yes, comment on commits.

@lunny lunny changed the title Inline comments on prs Inline comments on commits Nov 10, 2016
@bkcsoft
Copy link
Member

bkcsoft commented Dec 6, 2016

I can probably make a proof of concept for this sometime during the weekend or next week

@lunny
Copy link
Member Author

lunny commented Jan 26, 2017

@bkcsoft any update?

@strk
Copy link
Member

strk commented Jan 26, 2017

Aren't we going to do this with git-appraise ? See #733

@rikvdh rikvdh mentioned this issue Jan 26, 2017
Closed
@sokolovstas
Copy link

I can look at this, but this will be not so fast

@lunny lunny modified the milestones: 1.2.0, 1.1.0 Feb 14, 2017
@lunny
Copy link
Member Author

lunny commented Feb 14, 2017

Move this v1.2 since #733 has moved.

@lunny
Copy link
Member Author

lunny commented Feb 14, 2017

I have tried to do something. Comments on PR is not the same as comments on commits. These are two similar PRs. For comments on PR, all the comments should be indexed by the IssueID, treePath, lineNum and actionType(add line or del line). But for comments on commits, all the comments should be indexed by commitSHA, treePath, lineNum and actionType(add line or del line).

@lunny lunny mentioned this issue Feb 23, 2017
Open
20 tasks
@lunny lunny modified the milestones: 1.x.x, 1.2.0 Apr 20, 2017
@lunny lunny mentioned this issue May 31, 2017
Closed
@lunny lunny mentioned this issue Sep 1, 2017
Closed
@lcges
Copy link

lcges commented Sep 12, 2017

I send the draft as seen to comment on the code.
For some time I will show demo work.
1

@lcges
Copy link

lcges commented Sep 22, 2017

Hello.
I send you a preview of the model of action.
This is a static implementation - proof of concept

gitea_comment_code.zip

@daviian
Copy link
Member

daviian commented Sep 22, 2017 •
edited
Loading

@qdbdbp Looks great but I think a button to cancel the comment is missing. How does it look in unified mode?

@lcges
Copy link

lcges commented Sep 22, 2017

gitea_c_o_c.zip

I send updated versions.
I'm waiting for comments on this.

pasted image at 2017_09_22 03_04 pm

@lunny
Copy link
Member Author

lunny commented Sep 22, 2017

@qdbdbp I am working on a branch about this, I will send a PR today or last two days. I will copy your code to that PR.

@lunny
Copy link
Member Author

lunny commented Sep 22, 2017

@qdbdbp It seems only the first comment on the code line. how to show the second or third comment on the same line?

@lunny lunny mentioned this issue Sep 23, 2017
Closed
@lunny
Copy link
Member Author

lunny commented Sep 23, 2017

@qdbdbp I have sent a PR #2583 but I think maybe I have lost something from your zip. Please review the code and help me with the UI.

@lunny lunny changed the title Inline comments on commits Inline comments on commits and pull files Sep 23, 2017
@lcges
Copy link

lcges commented Sep 25, 2017

no problem. I will do what I need
I'll take your code and I'm already working on the correct code.

pasted image at 2017_09_25 08_30 am
pasted image at 2017_09_25 08_35 am

@tonivj5
Copy link
Contributor

tonivj5 commented Sep 25, 2017

@qdbdbp, what tool do you use to do those designs? 😅

@lcges
Copy link

lcges commented Sep 25, 2017

hi. I use it for quick drafts this tool:

https://mockflow.com/

@krombel krombel mentioned this issue Feb 26, 2018
Closed
@jeanlucmongrain
Copy link
Contributor

I don't mind to pay to have this feature... how much? who?

@lunny
Copy link
Member Author

lunny commented Mar 13, 2018

@bclermont we already have a wip pull request #2583.

@jeanlucmongrain
Copy link
Contributor

@lunny yeah, but it can't be merged, and haven't been updated in 6 months! I want to help to implement this feature

@lunny
Copy link
Member Author

lunny commented Mar 13, 2018

You could use https://www.bountysource.com/teams/go-gitea

@techknowlogick
Copy link
Member

@lunny thanks for posting that link. I added to the bounty.

@cobbzilla
Copy link

Thanks for the bounty link. I added $100 if this can be resolved within 6 months. This is the basically the only feature that I still miss after migrating from Github to Gitea. I will be super duper happy when Gitea supports in-line code reviewing for pull requests. Go Gitea team!

@jeanlucmongrain
Copy link
Contributor

I will give equivalent of 100$ in a crypto currency to whoever earn the bounty

@lafriks lafriks modified the milestones: 1.x.x, 1.5.0 Apr 2, 2018
@lafriks lafriks mentioned this issue Apr 2, 2018
Merged
23 tasks
@rc1021
Copy link

rc1021 commented May 4, 2018

Are there things to follow?

@lunny
Copy link
Member Author

lunny commented May 4, 2018

Please follow #3748

@lafriks lafriks modified the milestones: 1.5.0, 1.6.0 Jun 5, 2018
@tonivj5
Copy link
Contributor

tonivj5 commented Sep 6, 2018

Is comment in commits implemented? If it isn't implemented I think this should be reopen

@lunny
Copy link
Member Author

lunny commented Sep 7, 2018

@xxxTonixxx right, Only pull request comment was implemented by #3748 . @lafriks @JonasFranzDEV

@lunny
Copy link
Member Author

lunny commented Sep 7, 2018

But we could open another issue to keep this one closed.

@tonivj5
Copy link
Contributor

tonivj5 commented Sep 7, 2018 •
edited
Loading

👍, I will do it

@tonivj5 tonivj5 mentioned this issue Sep 9, 2018
Open
@lunny lunny changed the title Inline comments on commits and pull files Commits and pull files Sep 11, 2018
@lunny
Copy link
Member Author

lunny commented Sep 11, 2018

@xxxTonixxx Thank you!

lunny pushed a commit to lunny/gitea that referenced this issue Feb 7, 2019
@christopherjmedlin @jonasfranz
Add parsing support for tag GPG signatures (go-gitea#124)
6ef79e8 
* Add parsing support for tag GPG signatures

* Test that signature is not left in commit message

* Fix object not found error in test
@dmatetelki dmatetelki mentioned this issue Jul 4, 2019
Open
7 tasks
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
type/feature Completely new functionality. Can only be merged if feature freeze is not active. type/proposal The new feature has not been accepted yet but needs to be discussed first.
Projects
None yet
Milestone
1.6.0