start jobs immediately by default #82
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -438,13 +440,6 @@ func (s *Scheduler) StartAt(t time.Time) *Scheduler { | |||
| return s | |||
| } | |||
|
|
|||
| // StartImmediately sets the Jobs next run as soon as the scheduler starts | |||
| func (s *Scheduler) StartImmediately() *Scheduler { | |||
There was a problem hiding this comment.
This is a backward-incompatible change, right?
Is that ok?
There was a problem hiding this comment.
Maybe we could deprecate the fuction before removing it
There was a problem hiding this comment.
I like deprecating. Also, I made some updates. Setting the starts immediately value as true in the constructor and then false where appropriate in At, Start At, Weekday and Day of the Month
arjunmahishi
approved these changes
Nov 29, 2020
Streppel
approved these changes
Nov 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this do?
The default behavior will now be that jobs start immediately unless scheduled at a specific time, for a specific weekday or on a specific day of the month.
Which issue(s) does this PR fix/relate to?
List any changes that modify/break current functionality
Have you included tests for your changes?
Did you document any new/modified functionality?
example_test.goREADME.mdNotes