[BUG] Fix Data race when using RunByTag #356
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Minor format changes are |
JohnRoesler
approved these changes
Jul 20, 2022
|
@JohnRoesler Thanks for the review & merge! Do you by any chance have an insight of when the change will be released? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this do?
Resolves #350 Job lastRun was causing the data race when RunByTag. Wraps the
job.copyinScheduler.run()into separate method,addJobDetailsand added locks onjob.runCount,job.lastRun.Which issue(s) does this PR fix/relate to?
Resolves #350
List any changes that modify/break current functionality
Have you included tests for your changes?
Updated TestScheduler_RunByTag in
shceduler_test.goto simulate multiple tasks being run by tag.Did you document any new/modified functionality?
example_test.goREADME.mdNotes
Added
ErrInvalidFunctionParameters = errors.New("length of function parameters must match job function parameters")But if this case will never be happening, update thejob.error. Otherwise, it would be better to return the error.