Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make FindJobsByTag exported #268

Merged

Conversation

calvinmclean
Copy link

What does this do?

This exports the FindJobsByTag function so that it can be used outside of the package. This is really useful for updating Jobs or displaying the NextRun time.

Which issue(s) does this PR fix/relate to?

N/A

List any changes that modify/break current functionality

None (unless this was un-exported for a reason).

Have you included tests for your changes?

No because there is full coverage from this being used throughout the package. Let me know if I should add some specific tests.

Did you document any new/modified functionality?

  • Updated example_test.go
  • Updated README.md

Notes

Copy link
Contributor

@JohnRoesler JohnRoesler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@JohnRoesler JohnRoesler merged commit 5a66869 into go-co-op:main Dec 13, 2021
@calvinmclean calvinmclean deleted the feature/export-findJobsByTag branch April 11, 2024 03:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants