Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add job limit and remove after last run to chain #116

Merged
merged 5 commits into from
Feb 5, 2021

Conversation

JohnRoesler
Copy link
Contributor

What does this do?

  • adds LimitRunsTo and RemoveAfterLastRun to scheduler api to allow changing a behavior where a job added to a running scheduler cannot be limited to a single run.

Which issue(s) does this PR fix/relate to?

closes #115

List any changes that modify/break current functionality

Have you included tests for your changes?

👍 and cleaned up a bunch

Did you document any new/modified functionality?

  • Updated example_test.go
  • Updated README.md

Notes

job.go Outdated Show resolved Hide resolved
job.go Outdated Show resolved Hide resolved
@JohnRoesler JohnRoesler merged commit 3718e60 into go-co-op:master Feb 5, 2021
@JohnRoesler JohnRoesler deleted the issue-115 branch February 5, 2021 03:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] - Job with LimitRunsTo(1) runs twice
1 participant