fix calculateMonths #104
Merged
fix calculateMonths #104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… base time is not consistency
JohnRoesler
dismissed
their stale review
i think the tests could use some enhancements
JohnRoesler
reviewed
Feb 2, 2021
JohnRoesler
reviewed
Feb 2, 2021
| @@ -191,7 +191,7 @@ func (s *Scheduler) calculateMonths(job *Job, lastRun time.Time) time.Duration { | |||
| nextRun = nextRun.AddDate(0, int(job.interval), daysDifference) | |||
| } | |||
| } | |||
| return s.until(lastRunRoundedMidnight, nextRun) | |||
| return s.until(lastRun, nextRun) | |||
There was a problem hiding this comment.
@sdw2330976 do you have a time scenario where this fails with lastRunRoundedMidnight? We can fake the time for a test, but ideally we could prove the old logic doesn't work with our test
Co-authored-by: John Roesler <[email protected]>
JohnRoesler
approved these changes
Feb 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when we use every month at some time,then calculate next run time use base time is not consistency
What does this do?
Which issue(s) does this PR fix/relate to?
List any changes that modify/break current functionality
Have you included tests for your changes?
Did you document any new/modified functionality?
example_test.goREADME.mdNotes