GSW-530 feat: swap router #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
r3v4s
force-pushed
the
GSW-530-feat-swap-router
branch
from
c0e8b38 to
8a4592c
Compare
notJoon
reviewed
Nov 6, 2023
notJoon
requested changes
Nov 6, 2023
Co-authored-by: Lee ByeongJun <[email protected]>
Co-authored-by: Lee ByeongJun <[email protected]>
Co-authored-by: Lee ByeongJun <[email protected]>
Co-authored-by: Lee ByeongJun <[email protected]>
Co-authored-by: Lee ByeongJun <[email protected]>
|
@notJoon bit of err found which I left in comments, and made function in getter_api recursive too as quotation |
notJoon
approved these changes
Nov 7, 2023
|
@mconcat branch is merged for further PR, but pls leave your comments :D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BestSwap()handles all type of swap (exactIn / exactOut), (singlePath, multiPath), (singlePool, multiPool)BestSwapDry()will return best route path depends on input paramtergno.land/r/fooBREAKING CHANGE
pool.Swap()will be deprecated next version, callrouter.BestSwap()