refactor(staker): add in-range staked liquidity tracker #438
Conversation
|
| @@ -611,6 +611,8 @@ func tickTransition(step StepComputations, zeroForOne bool, state SwapState, poo | |||
| newState.liquidity = liquidityMathAddDelta(state.liquidity, liquidityNet) | |||
| } | |||
|
|
|||
| pool.tickCrossHook(GetPoolPath(pool.token0Path, pool.token1Path, pool.fee), step.tickNext, zeroForOne) | |||
|
|
|||
There was a problem hiding this comment.
If you stack tickNext at this point, you're stacking the value before the change. If you want to stack the history of the change with tickTransition, it's better to record the updated tick in newState.tick.
| pool, ok := stakerPoolInfo[poolPath] | ||
| if !ok { | ||
| pool = StakerPoolInfo{ | ||
| totalStakedLiquidity: u256.Zero(), |
There was a problem hiding this comment.
The StakerPoolInfo type declaration is commented out.
| } | ||
| //pool.totalStakedLiquidity = liquidityMathAddDelta(pool.totalStakedLiquidity, liquidity) | ||
| if pn.PositionIsInRange(tokenId) { | ||
| pool.totalStakedLiquidityInRange = liquidityMathAddDelta(pool.totalStakedLiquidityInRange, liquidity) |
There was a problem hiding this comment.
In order to calculate the reward correctly, we need to distinguish when tokenId is inrange and when it is not.
Currently, the history of tokenIds records all tokenIds in deposits. I would recommend that we consider an additional ledger, depositTokenId[poolPath][tokenId], that manages all tokenId leases deposited in poolPath, and an additional ledger, inRangeTokenIdList[poolPath][tokenId], that manages inRagneTokenIds.
In some cases, it may not be an inRange, so you will need a global ledger and an inRange ledger.
No description provided.