refactor: router #431
refactor: router #431
Conversation
There was a problem hiding this comment.
@notJoon Please add a unit test for swap_multi.gno, swap_single.gno and wrap_unwrap.gno.
Functions that use Pool currently doesn't have tests yet. This is because there's no way to directly access and initialize the pool's state for now.
Can you create mockup data in pool that you can use for testing purposes in router? This seems essential tests. Think about a way to complete tests for this please.
|
| func i256Min(x, y *i256.Int) *i256.Int { | ||
| if x.Lt(y) { | ||
| return x | ||
| } | ||
| return y | ||
| } | ||
|
|
||
| func i256Max(x, y *i256.Int) *i256.Int { | ||
| if x.Gt(y) { | ||
| return x | ||
| } | ||
| return y | ||
| } | ||
|
|
There was a problem hiding this comment.
needs to be moved to the common package. maybe common/math?
There was a problem hiding this comment.
How about we make gnsmath and gnsutils in the root folder and put math related files to gnsmath, util related files to gnsutils?
Description
Refactor
routefile mainly.Remove
compute_routesandgno_helperfiles_swapfunctions and renamed them toswapInnerDrySwapRoutefunction and related methodsUpdate
"EXACT_IN","EXACT_OUT"strings. Additionally replace other hardcoded values with constants_helper_testfile for testing purposeFunctions that use
Poolcurrently doesn't have tests yet. This is because there's no way to directly access and initialize the pool's state for now.