GSW-1838 refactor: use avl.Tree in pool #430
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dongwon8247
changed the title
onlyhyde
requested changes
Dec 15, 2024
pool/tick_bitmap.gno
Outdated
|
|
||
| bitmap, exist := pool.tickBitmaps.Get(wordPosStr) | ||
| if !exist { | ||
| pool.tickBitmaps.Set(wordPosStr, u256.Zero()) |
| var bitPosAdjust uint | ||
| if lte { | ||
| bitPosAdjust = 1 | ||
| } |
There was a problem hiding this comment.
@r3v4s
If lte is false, explicitly set 0 to bitPosAdjust
The semantics of bitOffset seems more appropriate than bitPosAdjust.
r3v4s
force-pushed
the
refactor/pool_avl-instead-of-map
branch
from
adec74f to
bf8e09d
Compare
r3v4s
force-pushed
the
refactor/pool_avl-instead-of-map
branch
from
a926b6c to
71190c0
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refactor
avl.Treeinstead ofmapmaphas issue with processing pointer value as key