Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GSW-1839 refactor: helper test code integration and update gno.mod #427

Merged
merged 1 commit into from
Dec 10, 2024
Merged

GSW-1839 refactor: helper test code integration and update gno.mod #427

merged 1 commit into from
Dec 10, 2024

Conversation

onlyhyde
Copy link
Member

  • remove require in gno.mod
  • integrated helper test code

@onlyhyde
GSW-1839 refactor: helper test code integration and update gno.mod
1426a38 
- remove require in gno.mod
- integrated helper test code
@onlyhyde onlyhyde requested review from r3v4s and notJoon December 10, 2024 01:36
@onlyhyde onlyhyde self-assigned this Dec 10, 2024
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Dec 10, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
93.0% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

@onlyhyde onlyhyde merged commit 064ba86 into main Dec 10, 2024
1 of 3 checks passed
@onlyhyde onlyhyde deleted the refactor/position-contract branch December 10, 2024 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@r3v4s r3v4s r3v4s approved these changes

@notJoon notJoon notJoon approved these changes

Assignees

@onlyhyde onlyhyde

Labels
position refactoring
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@onlyhyde @notJoon @r3v4s