Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GSW-1458 feat: governance #331

Merged
merged 45 commits into from
Sep 4, 2024
Merged

GSW-1458 feat: governance #331

merged 45 commits into from
Sep 4, 2024

Conversation

r3v4s
Copy link
Member

@r3v4s r3v4s commented Aug 26, 2024 •
edited
Loading

feat

  1. xGNS
  • most likey grc20 token (but can not be transfered)
  • convert GNS to xGNS with ratio 1:1
  1. Governance Staker
  • stake xGNS
  • delegate / undelegate
  • collect reward (gns emission, protocol_fee distribution)
  • multi token support
  1. Governance
  • make / vote proposal
  • execute other contract's function
  • delegate cumulative
  • emergency halt

@r3v4s r3v4s self-assigned this Aug 26, 2024
@r3v4s r3v4s requested a review from notJoon August 26, 2024 10:42
@r3v4s r3v4s changed the title GSW-1509 feat: xGNS GSW-1458 feat: governance Aug 27, 2024
notJoon
notJoon reviewed Aug 27, 2024
View reviewed changes
gov/staker/staker.gno Outdated Show resolved Hide resolved
@r3v4s
Copy link
Member Author

r3v4s commented Aug 27, 2024

@notJoon It's draft PR. Please do not commit anything.

@r3v4s r3v4s force-pushed the GSW-1458-governance branch from f6268de to de51731 Compare August 27, 2024 11:17
@dongwon8247 dongwon8247 mentioned this pull request Aug 28, 2024
Open
@r3v4s r3v4s marked this pull request as ready for review August 30, 2024 07:32
notJoon
notJoon previously approved these changes Aug 30, 2024
View reviewed changes
dongwon8247
dongwon8247 approved these changes Aug 30, 2024
View reviewed changes
Copy link
Member

@dongwon8247 dongwon8247 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job!

dongwon8247
dongwon8247 previously approved these changes Aug 31, 2024
View reviewed changes
Copy link
Member

@dongwon8247 dongwon8247 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check my comments before merging this out

protocol_fee/protocol_fee.gno Outdated Show resolved Hide resolved
protocol_fee/protocol_fee.gno Outdated Show resolved Hide resolved
protocol_fee/protocol_fee.gno Outdated Show resolved Hide resolved
@r3v4s r3v4s dismissed stale reviews from dongwon8247 and notJoon via 2d9c649 September 1, 2024 12:24
@r3v4s r3v4s requested review from notJoon and dongwon8247 September 2, 2024 07:14
notJoon
notJoon previously approved these changes Sep 2, 2024
View reviewed changes
Copy link
Member

@notJoon notJoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works well 👍

@r3v4s r3v4s marked this pull request as draft September 2, 2024 11:49
@r3v4s
Copy link
Member Author

r3v4s commented Sep 2, 2024

changing to draft
WIP //

  1. Getter
  2. Partial Undelegation History

@r3v4s r3v4s marked this pull request as ready for review September 4, 2024 02:22
@r3v4s r3v4s requested review from notJoon and mconcat September 4, 2024 02:23
notJoon
notJoon previously approved these changes Sep 4, 2024
View reviewed changes
r3v4s and others added 22 commits September 4, 2024 18:13
@r3v4s
GSW-1529 fix: GetAverageDelegated()
b0e8462
@r3v4s
chore
09cf310
@r3v4s
GSW-1529 fix: GetDelegatedCumulative()
7091393
@r3v4s
GSW-1354 feat: emergency halt
c926e8d
@r3v4s
GSW-1364 feat: emergency halt
b7a2ab5
@r3v4s
testcase: fix
2da869e
@r3v4s @dongwon8247
Update protocol_fee/protocol_fee.gno
711e66c 
Co-authored-by: Dongwon <[email protected]>
@r3v4s @dongwon8247
Update protocol_fee/protocol_fee.gno
290260c 
Co-authored-by: Dongwon <[email protected]>
@r3v4s @dongwon8247
Update protocol_fee/protocol_fee.gno
bcb896f 
Co-authored-by: Dongwon <[email protected]>
@r3v4s
GSW-1547 test: fix testcases due to change of protocol_fee distributi…
737b561 
…on percent
@r3v4s
GSW-1512 feat: governance/staker getter
af00efc
@r3v4s
feat: emit event in gov/staker
cbb5070
@r3v4s
GSW-1570 feat: partial undelegation history
a2732e5
@r3v4s
chore: reorganize
fbccb87
@r3v4s
GSW-1512 feat: governance/gov getter
b76a190
@r3v4s
chore
26ac5ca
@r3v4s
GSW-1512 feat: governance/staker more getter
bf530c9
@r3v4s
feat: execute pre functions
449b6e6
@r3v4s
build: fix deploy issue
d155dfe
@r3v4s
fix: bugs
3e5797c
@r3v4s
test: makefile testing on live chain
6c5f9be
@r3v4s
feat(tmp): qa config
d883bfc
@r3v4s r3v4s force-pushed the GSW-1458-governance branch from bc720ca to d883bfc Compare September 4, 2024 09:13
@r3v4s r3v4s requested a review from notJoon September 4, 2024 09:13
@r3v4s r3v4s requested a review from onlyhyde September 4, 2024 09:36
onlyhyde
onlyhyde approved these changes Sep 4, 2024
View reviewed changes
Copy link
Member

@onlyhyde onlyhyde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@r3v4s r3v4s merged commit 2d1ea9a into main Sep 4, 2024
@r3v4s r3v4s deleted the GSW-1458-governance branch September 4, 2024 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@onlyhyde onlyhyde onlyhyde approved these changes

@notJoon notJoon notJoon approved these changes

@dongwon8247 dongwon8247 Awaiting requested review from dongwon8247

@mconcat mconcat Awaiting requested review from mconcat

Assignees

@r3v4s r3v4s

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@r3v4s @notJoon @onlyhyde @dongwon8247