GSW-1142 feat: gns (mint with permission) + pre-calculated halving amount #247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
notJoon
approved these changes
Jul 2, 2024
|
I'm not sure if having the GNS token contract inside the GnoSwap contracts is better than having it outside of the contracts. I find most of the prominent DEXes have its tokens outside of their core contracts, like Uniswap, Ekubo etc. What is the benefit of each? |
mconcat
approved these changes
Jul 2, 2024
|
We may need to change the name of the gns_halving to something more canonical, as it can confuse the users. TBD |
r3v4s
deleted the
GSW-1142-gns-mint-with-permission-and-pre-calculated-halving
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat new gns
mint with permission
-> only
emissioncontract can callmint with pre-calculated halving amount
2.1 every single year, we (have plan to) mint different number of gns
2.2 from yearly amount, calculate daily amount > then calculate single block amount
2.3 with
lastMintedHeightvariable, calculate amount of gns to mint toemission--> which makes us we don't have to mint actually every block