Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove reviewers checklist from PR template #985

Merged
merged 1 commit into from
Jul 21, 2023
Merged

Conversation

moul
Copy link
Member

@moul moul commented Jul 21, 2023

Wasn’t used.

Could make sense to keep the main description for the contributors. While having the reviewers checklist posted as a comment by a bot.

Checklists...

Contributors Checklist

  • Added new tests, or not needed, or not feasible
  • Provided an example (e.g. screenshot) to aid review or the PR is self-explanatory
  • Updated the official documentation or not needed
  • No breaking changes were made, or a BREAKING CHANGE: xxx message was included in the description
  • Added references to related issues and PRs
  • Provided any useful hints for running manual tests
  • Added new benchmarks to generated graphs, if any. More info here.

Maintainers Checklist

  • Checked that the author followed the guidelines in CONTRIBUTING.md
  • Checked the conventional-commit (especially PR title and verb, presence of BREAKING CHANGE: in the body)
  • Ensured that this PR is not a significant change or confirmed that the review/consideration process was appropriate for the change

Wasn’t used.

Could make sense to keep the main description for the contributors. While having the reviewers checklist posted as a comment by a bot.
@moul moul requested a review from a team as a code owner July 21, 2023 17:46
Copy link
Member

@thehowl thehowl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think us maintainers know what to do; we would mostly need the checklist for external contributors, not for internal contributions, and since for any reasonably sized change there's a bunch of us reviewing them, if there's any problem it will be readily pointed out.

Approving & merging.

@thehowl thehowl merged commit 9e3b5d5 into master Jul 21, 2023
@thehowl thehowl deleted the moul-patch-2 branch July 21, 2023 17:50
@ajnavarro
Copy link
Contributor

I think a list is also helpful for internal contributions. You will generally remember almost all the points, but you will surely miss some of them.

I prefer to have a checkbox in PRs than needing to remember to add tests. It makes the process simpler.

Doozers pushed a commit to Doozers/gno that referenced this pull request Aug 31, 2023
Wasn’t used.

Could make sense to keep the main description for the contributors. While having the reviewers checklist posted as a comment by a bot.
@moul moul added this to the 💡Someday/Maybe milestone Sep 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Archived in project
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants