Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(gnovm): categorize imports #3323

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

n0izn0iz
Copy link
Contributor

@n0izn0iz n0izn0iz commented Dec 11, 2024

This makes the imports utils split imports by file kinds, allowing to make explicit decisions about what imports to use at the various callsites

  • Create FileKind enum to categorize gno files, with variants Compiled, Test, Xtest and Filetest
  • Create GetFileKind util to derive the FileKind from a file name and body
  • Create ImportsMap type that maps FileKinds to lists of imports. It has a single method Merge to select and merge various imports from multiple FileKinds
  • Modify thepackages.Imports helper to return an ImportsMap instead of a []string and adapt callsites by usingImportMap.Merge to preserve existing behavior

This is something I need for #3304 and #2932 but to help reviews I made an atomic PR here instead

Signed-off-by: Norman Meier <[email protected]>
@github-actions github-actions bot added 📦 🤖 gnovm Issues or PRs gnovm related 📦 ⛰️ gno.land Issues or PRs gno.land package related labels Dec 11, 2024
@Gno2D2
Copy link
Collaborator

Gno2D2 commented Dec 11, 2024

🛠 PR Checks Summary

All Automated Checks passed. ✅

Manual Checks (for Reviewers):
  • SKIP: Do not block the CI for this PR
Read More

🤖 This bot helps streamline PR reviews by verifying automated checks and providing guidance for contributors and reviewers.

✅ Automated Checks (for Contributors):

🟢 Maintainers must be able to edit this pull request (more info)
🟢 The pull request head branch must be up-to-date with its base (more info)

☑️ Contributor Actions:
  1. Fix any issues flagged by automated checks.
  2. Follow the Contributor Checklist to ensure your PR is ready for review.
    • Add new tests, or document why they are unnecessary.
    • Provide clear examples/screenshots, if necessary.
    • Update documentation, if required.
    • Ensure no breaking changes, or include BREAKING CHANGE notes.
    • Link related issues/PRs, where applicable.
☑️ Reviewer Actions:
  1. Complete manual checks for the PR, including the guidelines and additional checks if applicable.
📚 Resources:
Debug
Automated Checks
Maintainers must be able to edit this pull request (more info)

If

🟢 Condition met
└── 🟢 The pull request was created from a fork (head branch repo: n0izn0iz/gno)

Then

🟢 Requirement satisfied
└── 🟢 Maintainer can modify this pull request

The pull request head branch must be up-to-date with its base (more info)

If

🟢 Condition met
└── 🟢 On every pull request

Then

🟢 Requirement satisfied
└── 🟢 Head branch (n0izn0iz:imports-map) is up to date with base (master): behind by 0 / ahead by 4

Manual Checks
**SKIP**: Do not block the CI for this PR

If

🟢 Condition met
└── 🟢 On every pull request

Can be checked by

  • Any user with comment edit permission

Copy link

codecov bot commented Dec 11, 2024

Codecov Report

Attention: Patch coverage is 72.13115% with 17 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
gnovm/pkg/packages/imports.go 50.00% 14 Missing and 1 partial ⚠️
gnovm/pkg/doc/dirs.go 66.66% 1 Missing ⚠️
gnovm/pkg/gnomod/pkg.go 66.66% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

@n0izn0iz n0izn0iz marked this pull request as ready for review December 11, 2024 10:34
@Kouteki Kouteki requested a review from thehowl December 11, 2024 12:30
@n0izn0iz n0izn0iz changed the title feat: categorize imports feat(gnovm): categorize imports Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📦 ⛰️ gno.land Issues or PRs gno.land package related 📦 🤖 gnovm Issues or PRs gnovm related
Projects
Status: In Review
Development

Successfully merging this pull request may close these issues.

2 participants