Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: impl empty statement exec #3252

Merged
merged 2 commits into from
Dec 4, 2024
Merged

fix: impl empty statement exec #3252

merged 2 commits into from
Dec 4, 2024

Conversation

petar-dambovaliev
Copy link
Contributor

Implement empty statement in the runtime exec.

Closes #3202

@Gno2D2
Copy link
Collaborator

Gno2D2 commented Nov 30, 2024

I'm a bot that assists the Gno Core team in maintaining this repository. My role is to ensure that contributors understand and follow our guidelines, helping to streamline the development process.

The following requirements must be fulfilled before a pull request can be merged.
Some requirement checks are automated and can be verified by the CI, while others need manual verification by a staff member.

These requirements are defined in this configuration file.

Automated Checks

🔴 Maintainers must be able to edit this pull request
🔴 The pull request head branch must be up-to-date with its base

Manual Checks

No manual checks match this pull request.

Debug
Automated Checks
Maintainers must be able to edit this pull request

If

🟢 Condition met
└── 🟢 On every pull request

Then

🔴 Requirement not satisfied
└── 🔴 Maintainer can modify this pull request

The pull request head branch must be up-to-date with its base

If

🟢 Condition met
└── 🟢 On every pull request

Then

🔴 Requirement not satisfied
└── 🔴 Head branch (3202) is up to date with base (master): behind by 4 / ahead by 2

Copy link

codecov bot commented Nov 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

@Kouteki Kouteki added the in focus Core team is prioritizing this work label Dec 1, 2024
@petar-dambovaliev
Copy link
Contributor Author

@mvertes can we merge this one?

Copy link
Contributor

@mvertes mvertes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Copy link
Member

@notJoon notJoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@zivkovicmilos zivkovicmilos merged commit 6585cad into master Dec 4, 2024
102 of 103 checks passed
@zivkovicmilos zivkovicmilos deleted the 3202 branch December 4, 2024 09:08
r3v4s pushed a commit to gnoswap-labs/gno that referenced this pull request Dec 10, 2024
Implement empty statement in the runtime exec.

Closes gnolang#3202
@Kouteki Kouteki removed the in focus Core team is prioritizing this work label Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📦 🤖 gnovm Issues or PRs gnovm related
Projects
Development

Successfully merging this pull request may close these issues.

Goto to end of block fails
6 participants