ci: add debug on github-bot matrix subcommand + fixes #3244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge RequirementsThe following requirements must be fulfilled before a pull request can be merged. These requirements are defined in this configuration file. Automated Checks🟢 Maintainers must be able to edit this pull request Details
Manual Checks
Details
|
Codecov ReportAttention: Patch coverage is 📢 Thoughts on this report? Let us know! |
aeddi
force-pushed
the
dev/aeddi/fix-bot
branch
from
31e238c to
462ac01
Compare
aeddi
force-pushed
the
dev/aeddi/fix-bot
branch
from
264c6c5 to
5c1edda
Compare
|
@moul does this comment change work for you? GnoCheckBot/demo#8 (comment) |
aeddi
force-pushed
the
dev/aeddi/fix-bot
branch
from
467c212 to
241a755
Compare
aeddi
changed the title
sw360cab
approved these changes
Dec 2, 2024
thehowl
approved these changes
Dec 2, 2024
r3v4s
pushed a commit
to gnoswap-labs/gno
that referenced
this pull request
Dec 10, 2024
This PR will allow debugging errors of [this type](https://github.com/gnolang/gno/actions/runs/12072757244) that unfortunately cannot be tested locally since they rely on the context of GitHub Actions. Since I also had to add flags to the matrix subcommand, I moved the two matrix and check subcommands into subfolders. This PR also modify the comment to stick to moul's request and fixes several Github Actions errors. Related to gnolang#3238 Changes: - gnolang@d11ad5a moves matrix and check subcommands to their own packages in internal - gnolang@462ac01 gnolang@5c1edda gnolang@ffdce93 adds a debug to matrix subcommand (print event input / matrix output) + direct output of matrix to GitHub Actions using a matrix-key flag - gnolang@6af501d embed comment template file as a string at compile time instead of opening it at runtime - gnolang@59c3ad6 modifies bot comment to meet [this requirements](gnolang#3238 (comment)) - gnolang@241a755 filter out from the matrix generation and the PR processing all issues or closed PRs (process / list only opened PRs) <details><summary>Contributors' checklist...</summary> - [x] Added new tests, or not needed, or not feasible - [x] Provided an example (e.g. screenshot) to aid review or the PR is self-explanatory - [x] Updated the official documentation or not needed - [x] No breaking changes were made, or a `BREAKING CHANGE: xxx` message was included in the description - [x] Added references to related issues and PRs - [x] Provided any useful hints for running manual tests </details> --------- Co-authored-by: Morgan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will allow debugging errors of this type that unfortunately cannot be tested locally since they rely on the context of GitHub Actions.
Since I also had to add flags to the matrix subcommand, I moved the two matrix and check subcommands into subfolders.
This PR also modify the comment to stick to moul's request and fixes several Github Actions errors.
Related to #3238
Changes:
Contributors' checklist...
BREAKING CHANGE: xxxmessage was included in the description