Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Preventing injecting methods on a non-exist PackageNode #3199

Draft
wants to merge 7 commits into
base: master
Choose a base branch
from
Draft

feat: Preventing injecting methods on a non-exist PackageNode #3199

wants to merge 7 commits into from

Conversation

notJoon
Copy link
Member

@notJoon notJoon commented Nov 26, 2024 •
edited
Loading

fix #1099

WIP

Contributors' checklist...
  • Added new tests, or not needed, or not feasible
  • Provided an example (e.g. screenshot) to aid review or the PR is self-explanatory
  • Updated the official documentation or not needed
  • No breaking changes were made, or a BREAKING CHANGE: xxx message was included in the description
  • Added references to related issues and PRs
  • Provided any useful hints for running manual tests

@github-actions github-actions bot added the 📦 🤖 gnovm Issues or PRs gnovm related label Nov 26, 2024
@codecov Codecov
Copy link

codecov bot commented Nov 26, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 75.00000% with 5 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
gnovm/pkg/gnolang/nodes.go 75.00% 3 Missing and 2 partials ⚠️

📢 Thoughts on this report? Let us know!

@dongwon8247 dongwon8247 mentioned this pull request Nov 27, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thehowl thehowl Awaiting requested review from thehowl

@ltzmaxwell ltzmaxwell Awaiting requested review from ltzmaxwell

At least 1 approving review is required to merge this pull request.

Assignees

@notJoon notJoon

Labels
📦 🤖 gnovm Issues or PRs gnovm related
Projects
🤝🏻 Partner: Onbloc
Status: In Review
🧙‍♂️gno.land core team
Status: Triage
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Issue: we should not allow injecting methods on a non-exist PackageNode
1 participant
@notJoon