feat: remove monoclock & add tz as chain param

[MikaelVallenet]

based on #3016

Contributors' checklist...

• Added new tests, or not needed, or not feasible
• Provided an example (e.g. screenshot) to aid review or the PR is self-explanatory
• Updated the official documentation or not needed
• No breaking changes were made, or a BREAKING CHANGE: xxx message was included in the description
• Added references to related issues and PRs
• Provided any useful hints for running manual tests

[codecov]

Codecov Report

Attention: Patch coverage is 60.50269% with 220 lines in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
gnovm/tests/file.go	59.70%	191 Missing and 29 partials ⚠️

📢 Thoughts on this report? Let us know!

[MikaelVallenet]

Hi @moul,

I see two ways to make a constant parameter as discussed in the last contributor call

• the first would be to add the chain timezone parameter in the genesis.json file in the same way as a chain-id
• the second would be to add a const prefix to the genesis_params.toml file, for example const:chain_tz, from which point on this parameter would be treated differently, notably in Setters, where it would not be modifiable.

I see an advantage in the second option, which is that you can easily change a parameter from const to non-const, whereas in the first option the timezone won't be modifiable regardless of the configuration. Now, do we want the tz to be modifiable on certain chains?

If you see a third or more options, don't hesitate.
What do you think?

[Gno2D2]

I'm a bot that assists the Gno Core team in maintaining this repository. My role is to ensure that contributors understand and follow our guidelines, helping to streamline the development process.

The following requirements must be fulfilled before a pull request can be merged.
Some requirement checks are automated and can be verified by the CI, while others need manual verification by a staff member.

These requirements are defined in this configuration file.

Automated Checks

🟢 Maintainers must be able to edit this pull request (more info)
🔴 The pull request head branch must be up-to-date with its base (more info)

Manual Checks

No manual checks match this pull request.

Debug

Automated Checks

Maintainers must be able to edit this pull request (more info)

If

🟢 Condition met
└── 🟢 The pull request was created from a fork (head branch repo: MikaelVallenet/gno)

Then

🟢 Requirement satisfied
└── 🟢 Maintainer can modify this pull request

The pull request head branch must be up-to-date with its base (more info)

If

🟢 Condition met
└── 🟢 On every pull request

Then

🔴 Requirement not satisfied
└── 🔴 Head branch (MikaelVallenet:dev/mikaelvallenet/feat/time-remove-mono-add-tz-as-chain-param) is up to date with base (master): behind by 53 / ahead by 16

[moul]

I was also considering adding a global variable to the standard library that is set to a custom value during its func init(). This would allow it to function like a "dynamic" constant within the package, eliminating the need to pass this fixed value everywhere. It would also make the standard library independent of parameters, std, and so on.

What do you think?

[MikaelVallenet]

I was also considering adding a global variable to the standard library that is set to a custom value during its func init(). This would allow it to function like a "dynamic" constant within the package, eliminating the need to pass this fixed value everywhere. It would also make the standard library independent of parameters, std, and so on.

What do you think?

Yeah i think it could be a good idea, at least for now and make it easier to implement.
I will update the code to do this in the following days 🚀