Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gnovm): forbid star expression when value is nil #3053

Merged
merged 1 commit into from
Oct 30, 2024

Conversation

omarsy
Copy link
Member

@omarsy omarsy commented Oct 30, 2024

close: #3052

Contributors' checklist...
  • Added new tests, or not needed, or not feasible
  • Provided an example (e.g. screenshot) to aid review or the PR is self-explanatory
  • Updated the official documentation or not needed
  • No breaking changes were made, or a BREAKING CHANGE: xxx message was included in the description
  • Added references to related issues and PRs
  • Provided any useful hints for running manual tests

@github-actions github-actions bot added the 📦 🤖 gnovm Issues or PRs gnovm related label Oct 30, 2024
@omarsy omarsy requested review from thehowl and ltzmaxwell October 30, 2024 21:46
@omarsy omarsy marked this pull request as ready for review October 30, 2024 21:46
Copy link

codecov bot commented Oct 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.30%. Comparing base (e9640ef) to head (421a4ac).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3053      +/-   ##
==========================================
- Coverage   63.31%   63.30%   -0.01%     
==========================================
  Files         548      548              
  Lines       78509    78511       +2     
==========================================
- Hits        49705    49700       -5     
- Misses      25450    25455       +5     
- Partials     3354     3356       +2     
Flag Coverage Δ
contribs/gnodev 59.94% <ø> (-0.63%) ⬇️
contribs/gnofaucet 14.82% <ø> (-0.95%) ⬇️
gno.land 67.18% <ø> (ø)
gnovm 67.88% <100.00%> (+<0.01%) ⬆️
misc/genstd 79.72% <ø> (ø)
tm2 62.40% <ø> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ltzmaxwell ltzmaxwell merged commit 8ec556e into gnolang:master Oct 30, 2024
126 checks passed
@omarsy omarsy deleted the fix/3052 branch November 1, 2024 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📦 🤖 gnovm Issues or PRs gnovm related
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

should not indirect nil
3 participants