Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(genesis): deployerAddress passed as parameter #2986

Conversation

Villaquiranm
Copy link
Contributor

@Villaquiranm Villaquiranm commented Oct 19, 2024

closes #2573

Contributors' checklist...
  • Added new tests, or not needed, or not feasible
  • Provided an example (e.g. screenshot) to aid review or the PR is self-explanatory
  • Updated the official documentation or not needed
  • No breaking changes were made, or a BREAKING CHANGE: xxx message was included in the description
  • Added references to related issues and PRs
  • Provided any useful hints for running manual tests

@github-actions github-actions bot added the 📦 ⛰️ gno.land Issues or PRs gno.land package related label Oct 19, 2024
Copy link

codecov bot commented Oct 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

@Villaquiranm Villaquiranm force-pushed the feat/configure-address-deployer-genesis branch from 2c5540c to c19da20 Compare October 19, 2024 21:23
@Villaquiranm Villaquiranm changed the title feat(genesis): deployerAddres passed as parameter feat(genesis): deployerAddress passed as parameter Oct 19, 2024
@omarsy omarsy force-pushed the feat/configure-address-deployer-genesis branch from c19da20 to 2d8ba6c Compare October 19, 2024 21:29
@Villaquiranm Villaquiranm force-pushed the feat/configure-address-deployer-genesis branch from 2d8ba6c to c19da20 Compare October 19, 2024 21:30
@Villaquiranm Villaquiranm marked this pull request as ready for review October 20, 2024 07:34
@Villaquiranm Villaquiranm requested review from zivkovicmilos and a team as code owners October 20, 2024 07:34
@Villaquiranm
Copy link
Contributor Author

closes #2573

Copy link
Member

@moul moul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Depends on #2824

@jefft0 jefft0 added the review/triage-pending PRs opened by external contributors that are waiting for the 1st review label Oct 21, 2024
@thehowl
Copy link
Member

thehowl commented Oct 30, 2024

No longer blocked; please merge master to fix the go.mod CI and fix lint CI. I'll wait for the review team to do a first pass.

// Load Genesis TXs
genesisTxs, err := gnoland.LoadGenesisTxsFile(c.genesisTxsFile, c.chainID, c.genesisRemote)
if err != nil {
return fmt.Errorf("unable to load genesis txs file: %w", err)
}

signer := genesisTxs[0].Msgs[0].GetSigners()[0]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the first tx is not necessarily what has been passed to TxsAddPackages command

also loading the examples here will be removed from what I understand so maybe we should not change his file until #1952 is fixed

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the review @n0izn0iz changed back while waiting for that change :)

@jefft0
Copy link
Contributor

jefft0 commented Nov 5, 2024

Hello @Villaquiranm . This PR closes issue #2573 . I see that it adds a way to configure the deployer address from the command line. But the issue also says "". But the issue also says to change to a default "deployer address like g1sh0uldn0thappen..." Is this still needed?

@Villaquiranm
Copy link
Contributor Author

Hey @jefft0 thanks for your review.
I mean I could put g1sh0uldn0thappen but that being a non valid address, maybe it is better to fail if the parameter is not given ? that's why I left it as it was but sure I could put 'g1sh0uldn0thappen'

Hello @Villaquiranm . This PR closes issue #2573 . I see that it adds a way to configure the deployer address from the command line. But the issue also says "". But the issue also says to change to a default "deployer address like g1sh0uldn0thappen..." Is this still needed?

@jefft0
Copy link
Contributor

jefft0 commented Nov 6, 2024

Hey @jefft0 thanks for your review. I mean I could put g1sh0uldn0thappen but that being a non valid address, maybe it is better to fail if the parameter is not given ? that's why I left it as it was but sure I could put 'g1sh0uldn0thappen'

Hello @Villaquiranm . This PR closes issue #2573 . I see that it adds a way to configure the deployer address from the command line. But the issue also says "". But the issue also says to change to a default "deployer address like g1sh0uldn0thappen..." Is this still needed?

Hi @Villaquiranm . I can't tell you the answer. My job as part of "review/triage" is to anticipate the questions that the core devs would ask during their final review, and to make sure they have been considered.

The mnemonic (and private key) of address g1jg8mtutu9khhfwc4nxmuhcpftf0pajdhfvsqf5 is well-known, and thehowl suggests that it shouldn't be the default (like it is in your PR). What do you think are the options to deal with this?

@zivkovicmilos zivkovicmilos marked this pull request as draft November 12, 2024 14:00
@jefft0 jefft0 removed the review/triage-pending PRs opened by external contributors that are waiting for the 1st review label Nov 13, 2024
@jefft0
Copy link
Contributor

jefft0 commented Nov 13, 2024

Removed the review/triage-pending label because zivkovicmilos changed this PR to draft status.

@github-actions github-actions bot added the 📦 🌐 tendermint v2 Issues or PRs tm2 related label Nov 24, 2024
@Villaquiranm Villaquiranm force-pushed the feat/configure-address-deployer-genesis branch from 87f0bc4 to cd84306 Compare November 24, 2024 15:56
@Villaquiranm Villaquiranm force-pushed the feat/configure-address-deployer-genesis branch from cd84306 to a9d7766 Compare November 24, 2024 15:57
@Villaquiranm Villaquiranm force-pushed the feat/configure-address-deployer-genesis branch from 4fed6a4 to 7dc694d Compare November 29, 2024 18:18
@Gno2D2
Copy link
Collaborator

Gno2D2 commented Nov 29, 2024

Merge Requirements

The following requirements must be fulfilled before a pull request can be merged.
Some requirement checks are automated and can be verified by the CI, while others need manual verification by a staff member.

These requirements are defined in this configuration file.

Automated Checks

🔴 Maintainers must be able to edit this pull request
🔴 The pull request head branch must be up-to-date with its base

Details
Maintainers must be able to edit this pull request

If

🟢 Condition met
└── 🟢 On every pull request

Then

🔴 Requirement not satisfied
└── 🔴 Maintainer can modify this pull request

The pull request head branch must be up-to-date with its base

If

🟢 Condition met
└── 🟢 On every pull request

Then

🔴 Requirement not satisfied
└── 🔴 Head branch (TERITORI:feat/configure-address-deployer-genesis) is up to date with base (master): behind by 21 / ahead by 18

Manual Checks

  • The pull request description provides enough details
Details
The pull request description provides enough details

If

🟢 Condition met
└── 🟢 Not (🔴 Pull request author is a member of the team: core-contributors)

Can be checked by

  • team core-contributors

@Villaquiranm Villaquiranm force-pushed the feat/configure-address-deployer-genesis branch 2 times, most recently from 7a97564 to 420b8b8 Compare November 29, 2024 18:22
@Villaquiranm Villaquiranm force-pushed the feat/configure-address-deployer-genesis branch from 420b8b8 to fa9a157 Compare November 29, 2024 18:23
zivkovicmilos added a commit that referenced this pull request Dec 4, 2024
closes #2573

Had to change the PR from a personal repository as the pipeline was
failing
old PR: #2986
<!-- please provide a detailed description of the changes made in this
pull request. -->

<details><summary>Contributors' checklist...</summary>

- [ ] Added new tests, or not needed, or not feasible
- [ ] Provided an example (e.g. screenshot) to aid review or the PR is
self-explanatory
- [ ] Updated the official documentation or not needed
- [ ] No breaking changes were made, or a `BREAKING CHANGE: xxx` message
was included in the description
- [ ] Added references to related issues and PRs
- [ ] Provided any useful hints for running manual tests
</details>

---------

Co-authored-by: 6h057 <[email protected]>
Co-authored-by: Miloš Živković <[email protected]>
r3v4s pushed a commit to gnoswap-labs/gno that referenced this pull request Dec 10, 2024
closes gnolang#2573

Had to change the PR from a personal repository as the pipeline was
failing
old PR: gnolang#2986
<!-- please provide a detailed description of the changes made in this
pull request. -->

<details><summary>Contributors' checklist...</summary>

- [ ] Added new tests, or not needed, or not feasible
- [ ] Provided an example (e.g. screenshot) to aid review or the PR is
self-explanatory
- [ ] Updated the official documentation or not needed
- [ ] No breaking changes were made, or a `BREAKING CHANGE: xxx` message
was included in the description
- [ ] Added references to related issues and PRs
- [ ] Provided any useful hints for running manual tests
</details>

---------

Co-authored-by: 6h057 <[email protected]>
Co-authored-by: Miloš Živković <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📦 🌐 tendermint v2 Issues or PRs tm2 related 📦 ⛰️ gno.land Issues or PRs gno.land package related
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

change default genesis package creator, and add way to configure it
6 participants