feat(genesis): deployerAddress passed as parameter #2986

Villaquiranm · 2024-10-19T21:20:49Z

closes #2573

Contributors' checklist...

Added new tests, or not needed, or not feasible
Provided an example (e.g. screenshot) to aid review or the PR is self-explanatory
Updated the official documentation or not needed
No breaking changes were made, or a BREAKING CHANGE: xxx message was included in the description
Added references to related issues and PRs
Provided any useful hints for running manual tests

codecov · 2024-10-19T21:22:28Z

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

Co-authored-by: 6h057 <[email protected]>

Villaquiranm · 2024-10-20T07:37:59Z

closes #2573

moul

Depends on #2824

…ddress-deployer-genesis

thehowl · 2024-10-30T22:15:53Z

No longer blocked; please merge master to fix the go.mod CI and fix lint CI. I'll wait for the review team to do a first pass.

n0izn0iz · 2024-10-31T10:17:10Z

gno.land/cmd/gnoland/start.go

 	// Load Genesis TXs
 	genesisTxs, err := gnoland.LoadGenesisTxsFile(c.genesisTxsFile, c.chainID, c.genesisRemote)
 	if err != nil {
 		return fmt.Errorf("unable to load genesis txs file: %w", err)
 	}

+	signer := genesisTxs[0].Msgs[0].GetSigners()[0]


the first tx is not necessarily what has been passed to TxsAddPackages command

also loading the examples here will be removed from what I understand so maybe we should not change his file until #1952 is fixed

thanks for the review @n0izn0iz changed back while waiting for that change :)

jefft0 · 2024-11-05T08:39:54Z

Hello @Villaquiranm . This PR closes issue #2573 . I see that it adds a way to configure the deployer address from the command line. But the issue also says "". But the issue also says to change to a default "deployer address like g1sh0uldn0thappen..." Is this still needed?

Villaquiranm · 2024-11-05T18:49:50Z

Hey @jefft0 thanks for your review.
I mean I could put g1sh0uldn0thappen but that being a non valid address, maybe it is better to fail if the parameter is not given ? that's why I left it as it was but sure I could put 'g1sh0uldn0thappen'

Hello @Villaquiranm . This PR closes issue #2573 . I see that it adds a way to configure the deployer address from the command line. But the issue also says "". But the issue also says to change to a default "deployer address like g1sh0uldn0thappen..." Is this still needed?

jefft0 · 2024-11-06T07:38:39Z

Hey @jefft0 thanks for your review. I mean I could put g1sh0uldn0thappen but that being a non valid address, maybe it is better to fail if the parameter is not given ? that's why I left it as it was but sure I could put 'g1sh0uldn0thappen'

Hello @Villaquiranm . This PR closes issue #2573 . I see that it adds a way to configure the deployer address from the command line. But the issue also says "". But the issue also says to change to a default "deployer address like g1sh0uldn0thappen..." Is this still needed?

Hi @Villaquiranm . I can't tell you the answer. My job as part of "review/triage" is to anticipate the questions that the core devs would ask during their final review, and to make sure they have been considered.

The mnemonic (and private key) of address g1jg8mtutu9khhfwc4nxmuhcpftf0pajdhfvsqf5 is well-known, and thehowl suggests that it shouldn't be the default (like it is in your PR). What do you think are the options to deal with this?

jefft0 · 2024-11-13T07:50:24Z

Removed the review/triage-pending label because zivkovicmilos changed this PR to draft status.

…ddress-deployer-genesis

Gno2D2 · 2024-11-29T18:18:49Z

Merge Requirements

The following requirements must be fulfilled before a pull request can be merged.
Some requirement checks are automated and can be verified by the CI, while others need manual verification by a staff member.

These requirements are defined in this configuration file.

Automated Checks

🔴 Maintainers must be able to edit this pull request
🔴 The pull request head branch must be up-to-date with its base

Details

Maintainers must be able to edit this pull request

If

🟢 Condition met
└── 🟢 On every pull request

Then

🔴 Requirement not satisfied
└── 🔴 Maintainer can modify this pull request

The pull request head branch must be up-to-date with its base

If

🟢 Condition met
└── 🟢 On every pull request

Then

🔴 Requirement not satisfied
└── 🔴 Head branch (TERITORI:feat/configure-address-deployer-genesis) is up to date with base (master): behind by 21 / ahead by 18

Manual Checks

The pull request description provides enough details

Details

The pull request description provides enough details
If
🟢 Condition met
└── 🟢 Not (🔴 Pull request author is a member of the team: core-contributors)
Can be checked by

team core-contributors

closes #2573 Had to change the PR from a personal repository as the pipeline was failing old PR: #2986  <details><summary>Contributors' checklist...</summary> - [ ] Added new tests, or not needed, or not feasible - [ ] Provided an example (e.g. screenshot) to aid review or the PR is self-explanatory - [ ] Updated the official documentation or not needed - [ ] No breaking changes were made, or a `BREAKING CHANGE: xxx` message was included in the description - [ ] Added references to related issues and PRs - [ ] Provided any useful hints for running manual tests </details> --------- Co-authored-by: 6h057 <[email protected]> Co-authored-by: Miloš Živković <[email protected]>

closes gnolang#2573 Had to change the PR from a personal repository as the pipeline was failing old PR: gnolang#2986  <details><summary>Contributors' checklist...</summary> - [ ] Added new tests, or not needed, or not feasible - [ ] Provided an example (e.g. screenshot) to aid review or the PR is self-explanatory - [ ] Updated the official documentation or not needed - [ ] No breaking changes were made, or a `BREAKING CHANGE: xxx` message was included in the description - [ ] Added references to related issues and PRs - [ ] Provided any useful hints for running manual tests </details> --------- Co-authored-by: 6h057 <[email protected]> Co-authored-by: Miloš Živković <[email protected]>

github-actions bot assigned Villaquiranm Oct 19, 2024

github-actions bot added the 📦 ⛰️ gno.land Issues or PRs gno.land package related label Oct 19, 2024

feat(genesis): deployerAddres passed as parameter

c19da20

Co-authored-by: 6h057 <[email protected]>

Villaquiranm force-pushed the feat/configure-address-deployer-genesis branch from 2c5540c to c19da20 Compare October 19, 2024 21:23

Villaquiranm changed the title ~~feat(genesis): deployerAddres passed as parameter~~ feat(genesis): deployerAddress passed as parameter Oct 19, 2024

omarsy force-pushed the feat/configure-address-deployer-genesis branch from c19da20 to 2d8ba6c Compare October 19, 2024 21:29

Villaquiranm force-pushed the feat/configure-address-deployer-genesis branch from 2d8ba6c to c19da20 Compare October 19, 2024 21:30

Villaquiranm marked this pull request as ready for review October 20, 2024 07:34

Villaquiranm requested review from zivkovicmilos and a team as code owners October 20, 2024 07:34

moul requested changes Oct 20, 2024

View reviewed changes

jefft0 added the review/triage-pending PRs opened by external contributors that are waiting for the 1st review label Oct 21, 2024

Villaquiranm added 2 commits October 29, 2024 19:49

Merge branch 'master' of github.com:gnolang/gno into feat/configure-a…

6a14735

…ddress-deployer-genesis

Deal with merges conflicts

bf99a28

Villaquiranm added 2 commits October 31, 2024 07:46

Merge branch 'master' into feat/configure-address-deployer-genesis

5023914

fmt

616f65c

n0izn0iz suggested changes Oct 31, 2024

View reviewed changes

zxxma mentioned this pull request Nov 1, 2024

Teritori's Builder Journey gnolang/hackerspace#7

Open

remove modifications on gnolang/start.go

fe837a4

zivkovicmilos marked this pull request as draft November 12, 2024 14:00

jefft0 removed the review/triage-pending PRs opened by external contributors that are waiting for the 1st review label Nov 13, 2024

Villaquiranm added 2 commits November 22, 2024 16:45

Merge branch 'master' of github.com:gnolang/gno into feat/configure-a…

8c229e4

…ddress-deployer-genesis

make it work with validateSignatures

a1c0ff7

Villaquiranm added 6 commits November 24, 2024 14:22

Merge branch 'master' of github.com:gnolang/gno into feat/configure-a…

41f8bab

…ddress-deployer-genesis

revert type on loadPackage func

4e28eee

make tidy

1805ebc

temporarilly remove signature verification

82d9b88

Fix tests

5e2ca66

accountSequence zero on genesis transactions

d25215a

github-actions bot added the 📦 🌐 tendermint v2 Issues or PRs tm2 related label Nov 24, 2024

Fix test on ante.go

c0fa3db

Villaquiranm force-pushed the feat/configure-address-deployer-genesis branch from 87f0bc4 to cd84306 Compare November 24, 2024 15:56

raise time test

a9d7766

Villaquiranm force-pushed the feat/configure-address-deployer-genesis branch from cd84306 to a9d7766 Compare November 24, 2024 15:57

Villaquiranm mentioned this pull request Nov 27, 2024

change default genesis package creator, and add way to configure it #2573

Closed

Villaquiranm force-pushed the feat/configure-address-deployer-genesis branch from 4fed6a4 to 7dc694d Compare November 29, 2024 18:18

Villaquiranm force-pushed the feat/configure-address-deployer-genesis branch 2 times, most recently from 7a97564 to 420b8b8 Compare November 29, 2024 18:22

add key-name param

fa9a157

Villaquiranm force-pushed the feat/configure-address-deployer-genesis branch from 420b8b8 to fa9a157 Compare November 29, 2024 18:23

fix linter

4bfa3c3

Villaquiranm mentioned this pull request Nov 30, 2024

feat(genesis): deployerAddress passed as parameter #3253

Merged

6 tasks

Villaquiranm closed this Nov 30, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(genesis): deployerAddress passed as parameter #2986

feat(genesis): deployerAddress passed as parameter #2986

Villaquiranm commented Oct 19, 2024 •

edited by thehowl

Loading

codecov bot commented Oct 19, 2024 •

edited

Loading

Villaquiranm commented Oct 20, 2024

moul left a comment

thehowl commented Oct 30, 2024

n0izn0iz Oct 31, 2024

Villaquiranm Nov 4, 2024

jefft0 commented Nov 5, 2024

Villaquiranm commented Nov 5, 2024

jefft0 commented Nov 6, 2024

jefft0 commented Nov 13, 2024

Gno2D2 commented Nov 29, 2024 •

edited

Loading

If

Then

If

Then

If

Can be checked by

feat(genesis): deployerAddress passed as parameter #2986

feat(genesis): deployerAddress passed as parameter #2986

Conversation

Villaquiranm commented Oct 19, 2024 • edited by thehowl Loading

codecov bot commented Oct 19, 2024 • edited Loading

Codecov Report

Villaquiranm commented Oct 20, 2024

moul left a comment

Choose a reason for hiding this comment

thehowl commented Oct 30, 2024

n0izn0iz Oct 31, 2024

Choose a reason for hiding this comment

Villaquiranm Nov 4, 2024

Choose a reason for hiding this comment

jefft0 commented Nov 5, 2024

Villaquiranm commented Nov 5, 2024

jefft0 commented Nov 6, 2024

jefft0 commented Nov 13, 2024

Gno2D2 commented Nov 29, 2024 • edited Loading

Merge Requirements

Automated Checks

If

Then

If

Then

Manual Checks

If

Can be checked by

Villaquiranm commented Oct 19, 2024 •

edited by thehowl

Loading

codecov bot commented Oct 19, 2024 •

edited

Loading

Gno2D2 commented Nov 29, 2024 •

edited

Loading