-
Notifications
You must be signed in to change notification settings - Fork 383
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(genesis): deployerAddress passed as parameter #2986
feat(genesis): deployerAddress passed as parameter #2986
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know! |
Co-authored-by: 6h057 <[email protected]>
2c5540c
to
c19da20
Compare
c19da20
to
2d8ba6c
Compare
2d8ba6c
to
c19da20
Compare
closes #2573 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Depends on #2824
No longer blocked; please merge master to fix the go.mod CI and fix lint CI. I'll wait for the review team to do a first pass. |
gno.land/cmd/gnoland/start.go
Outdated
// Load Genesis TXs | ||
genesisTxs, err := gnoland.LoadGenesisTxsFile(c.genesisTxsFile, c.chainID, c.genesisRemote) | ||
if err != nil { | ||
return fmt.Errorf("unable to load genesis txs file: %w", err) | ||
} | ||
|
||
signer := genesisTxs[0].Msgs[0].GetSigners()[0] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the first tx is not necessarily what has been passed to TxsAddPackages
command
also loading the examples here will be removed from what I understand so maybe we should not change his file until #1952 is fixed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for the review @n0izn0iz changed back while waiting for that change :)
Hello @Villaquiranm . This PR closes issue #2573 . I see that it adds a way to configure the deployer address from the command line. But the issue also says "". But the issue also says to change to a default "deployer address like |
Hey @jefft0 thanks for your review.
|
Hi @Villaquiranm . I can't tell you the answer. My job as part of "review/triage" is to anticipate the questions that the core devs would ask during their final review, and to make sure they have been considered. The mnemonic (and private key) of address g1jg8mtutu9khhfwc4nxmuhcpftf0pajdhfvsqf5 is well-known, and thehowl suggests that it shouldn't be the default (like it is in your PR). What do you think are the options to deal with this? |
Removed the |
87f0bc4
to
cd84306
Compare
cd84306
to
a9d7766
Compare
4fed6a4
to
7dc694d
Compare
Merge RequirementsThe following requirements must be fulfilled before a pull request can be merged. These requirements are defined in this configuration file. Automated Checks🔴 Maintainers must be able to edit this pull request Details
Manual Checks
Details
|
7a97564
to
420b8b8
Compare
420b8b8
to
fa9a157
Compare
closes #2573 Had to change the PR from a personal repository as the pipeline was failing old PR: #2986 <!-- please provide a detailed description of the changes made in this pull request. --> <details><summary>Contributors' checklist...</summary> - [ ] Added new tests, or not needed, or not feasible - [ ] Provided an example (e.g. screenshot) to aid review or the PR is self-explanatory - [ ] Updated the official documentation or not needed - [ ] No breaking changes were made, or a `BREAKING CHANGE: xxx` message was included in the description - [ ] Added references to related issues and PRs - [ ] Provided any useful hints for running manual tests </details> --------- Co-authored-by: 6h057 <[email protected]> Co-authored-by: Miloš Živković <[email protected]>
closes gnolang#2573 Had to change the PR from a personal repository as the pipeline was failing old PR: gnolang#2986 <!-- please provide a detailed description of the changes made in this pull request. --> <details><summary>Contributors' checklist...</summary> - [ ] Added new tests, or not needed, or not feasible - [ ] Provided an example (e.g. screenshot) to aid review or the PR is self-explanatory - [ ] Updated the official documentation or not needed - [ ] No breaking changes were made, or a `BREAKING CHANGE: xxx` message was included in the description - [ ] Added references to related issues and PRs - [ ] Provided any useful hints for running manual tests </details> --------- Co-authored-by: 6h057 <[email protected]> Co-authored-by: Miloš Živković <[email protected]>
closes #2573
Contributors' checklist...
BREAKING CHANGE: xxx
message was included in the description