test(p/uint256): Increase Test Coverage for uint256 Package
#2931
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
notJoon
requested review from
jaekwon and
petar-dambovaliev
and removed request for
a team
github-actions
bot
added
the
🧾 package/realm
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2931 +/- ##
==========================================
- Coverage 63.39% 63.39% -0.01%
==========================================
Files 565 565
Lines 79390 79390
==========================================
- Hits 50329 50327 -2
- Misses 25673 25674 +1
- Partials 3388 3389 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
jefft0
reviewed
Oct 10, 2024
jefft0
added
the
review/triage-pending
jefft0
approved these changes
Oct 18, 2024
jefft0
removed
the
review/triage-pending
|
Removed the "review/triage-pending" label because jefft0 approved. Ready for core dev review. |
thehowl
changed the title
uint256 Packageuint256 Package
thehowl
approved these changes
Oct 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Increased the test coverage of the
p/demo/uint256package. Previously, only about 40% was covered, but now it has increased to 90% (checked in go).The existing implementation of the uint256 function is unmodified except for modifying it to use the strconv package.
BREAKING CHANGE: xxxmessage was included in the description