-
Notifications
You must be signed in to change notification settings - Fork 383
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add strings.Replacer structure on native libraries #2816
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2816 +/- ##
==========================================
+ Coverage 60.84% 61.03% +0.18%
==========================================
Files 563 564 +1
Lines 75190 75434 +244
==========================================
+ Hits 45753 46039 +286
+ Misses 26068 26009 -59
- Partials 3369 3386 +17
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
more than these tags, which are still good, i'm looking for tooling which can help us compare go stdlibs and gno stdlibs there was a pr by an external contributor which was stopped at one point: #1425 if you want, you can continue his work, minding the unaddressed comments i made - i'd highly appreciate it ;) |
Sure I would like to take a look @thehowl 👍 |
prerequisite of #2802
This pull request ports the files:
from the Golang standard library.
I added some tags on the code with the hope it will help to review the code and to launch discussion if neccessary.
I could after remove these changes
Contributors' checklist...
BREAKING CHANGE: xxx
message was included in the description