feat: In the gnokey CLI, add command to update the password #2700
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jeff Thompson <[email protected]>
github-actions
bot
added
📦 🌐 tendermint v2
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2700 +/- ##
==========================================
+ Coverage 60.95% 60.97% +0.02%
==========================================
Files 564 565 +1
Lines 75273 75314 +41
==========================================
+ Hits 45884 45926 +42
+ Misses 26019 26015 -4
- Partials 3370 3373 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
gfanton
approved these changes
Aug 14, 2024
There was a problem hiding this comment.
LGTM
In the meantime, do we really need this command? You can simply export and re-import the key and set a new password. It's not like you will update your password every day.
On the other hand, this command doesn't seem to cause any harm, so I suppose it's fine to have it.
thehowl
approved these changes
Oct 2, 2024
Signed-off-by: Jeff Thompson <[email protected]>
Kouteki
added
the
review/triage-pending
Signed-off-by: Jeff Thompson <[email protected]>
Signed-off-by: Jeff Thompson <[email protected]>
thehowl
approved these changes
Oct 4, 2024
jefft0
added
review/triage-pending
Kouteki
removed
the
review/triage-pending
This was referenced Oct 16, 2024
jefft0
added a commit
to gnolang/gnonative
that referenced
this pull request
Oct 17, 2024
In PR gnolang/gno#2700, the keybase API method `Update` is renamed to `Rotate` because "Update" is too general. (This method only changes the password.) We want Gno Native Kit to closely follow the core APIs, so this PR renames `UpdatePassword` to `RotatePassword`. * In go.mod, use the latest gnolang/gno . * In the API, rename UpdatePassword to RotatePassword. Run `make regenerate` . * Push to buf the latest API and update expo dependencies. --------- Signed-off-by: Jeff Thompson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
KeybaseAPI supports a method to change the password of a key. It is currently calledUpdatewhich is confusing. This PR renames the API function toRotateand adds the "rotate" command to the gnokey CLI.BREAKING CHANGE: The Keybase API function
Updateis renamed toRotate. (Note: I haven't seen code using this function, so it should be minimal impact.)Contributors' checklist...
BREAKING CHANGE: xxxmessage was included in the description