-
Notifications
You must be signed in to change notification settings - Fork 384
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(gnodev): txs manipulation ability #2286
Conversation
Signed-off-by: gfanton <[email protected]>
…fting Signed-off-by: gfanton <[email protected]>
Signed-off-by: gfanton <[email protected]>
Signed-off-by: gfanton <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2286 +/- ##
==========================================
- Coverage 54.92% 54.90% -0.02%
==========================================
Files 594 595 +1
Lines 79297 79447 +150
==========================================
+ Hits 43550 43618 +68
- Misses 32457 32533 +76
- Partials 3290 3296 +6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: gfanton <[email protected]>
Signed-off-by: gfanton <[email protected]>
Signed-off-by: gfanton <[email protected]>
Signed-off-by: gfanton <[email protected]>
Signed-off-by: gfanton <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there any way to just load a tx each time it starts without having to first export the entire state? Also, it doesn't seem consistent to have a separate flag for balances but not for transactions when they are both part of the genesis file. Maybe they could be all combined into the genesis file and let the user choose the file contents -- one of three options:
- it is an actual genesis data struct
- it is only balances
- it is only txs
Though that could be confusing. I think it is fair to say that someone would want to only start the node with a single tx without having to first export the entire state -- much the same how someone would want to start the node with a single balance without having to first export the entire state. So maybe they should be three separate flags where the genesis file always gets loaded first and any additional balances or txs are appended.
Signed-off-by: gfanton <[email protected]>
Signed-off-by: gfanton <[email protected]>
Thinking more about this, I believe we should not authorize |
Signed-off-by: gfanton <[email protected]>
Signed-off-by: gfanton <[email protected]>
1084072
to
a35e7a7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice job. I left a few nitpick comments and questions. The feature to apply and undo transactions is pretty cool 😎
Signed-off-by: gfanton <[email protected]>
Signed-off-by: gfanton <[email protected]>
Signed-off-by: gfanton <[email protected]>
Signed-off-by: gfanton <[email protected]>
Signed-off-by: gfanton <[email protected]>
Waiting on @leohhhn to update the documentation |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing feature, salute 🫡
Wen state viewer in gnodev
@gfanton |
Signed-off-by: gfanton <[email protected]>
Signed-off-by: gfanton <[email protected]>
Signed-off-by: gfanton <[email protected]>
Signed-off-by: gfanton <[email protected]>
Signed-off-by: gfanton <[email protected]>
Signed-off-by: gfanton <[email protected]>
Signed-off-by: gfanton <[email protected]>
Signed-off-by: gfanton <[email protected]>
Signed-off-by: gfanton <[email protected]>
Signed-off-by: gfanton <[email protected]>
Signed-off-by: gfanton <[email protected]>
Signed-off-by: gfanton <[email protected]>
@zivkovicmilos I will updated this in a future PR. At the moment, it doesn't take into account the type of the event and just logs it with a |
Signed-off-by: gfanton <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Played around with it a bit, super cool. Docs look good 💯
Signed-off-by: gfanton <[email protected]>
Signed-off-by: gfanton <[email protected]>
3c91107
to
c6f8da2
Compare
This PR adds the ability to manipulate transactions:
P
andN
commands.Ctrl+S
and restore it later withCtrl+R
(reset command).E
command.-genesis-file
flag.TODO:Contributors' checklist...
BREAKING CHANGE: xxx
message was included in the description