-
Notifications
You must be signed in to change notification settings - Fork 384
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: use blank identifier constants #2158
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, except for the comment
Did you forget to push the changes where you revert the changes in the comments? |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2158 +/- ##
==========================================
- Coverage 49.93% 49.92% -0.01%
==========================================
Files 576 576
Lines 77827 77827
==========================================
- Hits 38864 38857 -7
- Misses 35839 35845 +6
- Partials 3124 3125 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Replaces "_" with blank identifier constants.
Replaces "_" with blank identifier constants.