Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use blank identifier constants #2158

Merged
merged 6 commits into from
May 28, 2024

Conversation

deelawn
Copy link
Contributor

@deelawn deelawn commented May 21, 2024

Replaces "_" with blank identifier constants.

@deelawn deelawn requested review from jaekwon, moul and piux2 as code owners May 21, 2024 08:01
@github-actions github-actions bot added the 📦 🤖 gnovm Issues or PRs gnovm related label May 21, 2024
gnovm/pkg/gnolang/nodes.go Outdated Show resolved Hide resolved
gnovm/pkg/gnolang/values.go Outdated Show resolved Hide resolved
gnovm/pkg/gnolang/values.go Outdated Show resolved Hide resolved
gnovm/pkg/gnolang/values.go Outdated Show resolved Hide resolved
gnovm/pkg/gnolang/preprocess.go Outdated Show resolved Hide resolved
Copy link
Member

@thehowl thehowl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, except for the comment

@thehowl
Copy link
Member

thehowl commented May 28, 2024

Did you forget to push the changes where you revert the changes in the comments?

Copy link

codecov bot commented May 28, 2024

Codecov Report

Attention: Patch coverage is 26.92308% with 19 lines in your changes are missing coverage. Please review.

Project coverage is 49.92%. Comparing base (3cc4952) to head (7e2bb75).
Report is 1 commits behind head on master.

Files Patch % Lines
gnovm/pkg/gnolang/preprocess.go 26.66% 4 Missing and 7 partials ⚠️
gnovm/pkg/gnolang/nodes.go 20.00% 1 Missing and 3 partials ⚠️
gnovm/pkg/gnolang/machine.go 0.00% 0 Missing and 2 partials ⚠️
gnovm/pkg/gnolang/helpers.go 0.00% 1 Missing ⚠️
gnovm/pkg/gnolang/values.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2158      +/-   ##
==========================================
- Coverage   49.93%   49.92%   -0.01%     
==========================================
  Files         576      576              
  Lines       77827    77827              
==========================================
- Hits        38864    38857       -7     
- Misses      35839    35845       +6     
- Partials     3124     3125       +1     
Flag Coverage Δ
gnovm 44.94% <26.92%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@thehowl thehowl merged commit 055018a into gnolang:master May 28, 2024
13 of 14 checks passed
@deelawn deelawn deleted the chore/blank-identifer branch May 28, 2024 17:57
omarsy pushed a commit to TERITORI/gno that referenced this pull request Jun 3, 2024
Replaces "_" with blank identifier constants.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📦 🤖 gnovm Issues or PRs gnovm related
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants