fix: limitation for length of package/realm path

[thinhnx-var]

Contributors' checklist...

• Added new tests, or not needed, or not feasible
• Provided an example (e.g. screenshot) to aid review or the PR is self-explanatory
• Updated the official documentation or not needed
• No breaking changes were made, or a BREAKING CHANGE: xxx message was included in the description
• Added references to related issues and PRs
• Provided any useful hints for running manual tests
• Added new benchmarks to generated graphs, if any. More info here.

[thinhnx-var]

relate to #2053

[zivkovicmilos]

Thank you for adding this guard 🙏

There are some things that need to be addressed before moving forward, but overall the PR looks good 💯

[petar-dambovaliev]

Here, we are trying to kill a fly with a thermal nuclear weapon (a regex).
There are 2 ways this can be implemented reasonably.

1. calling the builtin function len and the limit being imposed on the number of bytes
2. calling utf8.RuneCountInString and the limit being imposed on the number of characters

I personally think you should use len and limit the path to 256 bytes because it still does the job but it is much faster than the alternative.

[thinhnx-var]

Here, we are trying to kill a fly with a thermal nuclear weapon (a regex). There are 2 ways this can be implemented reasonably.

1. calling the builtin function len and the limit being imposed on the number of bytes
2. calling utf8.RuneCountInString and the limit being imposed on the number of characters

I personally think you should use len and limit the path to 256 bytes because it still does the job but it is much faster than the alternative.

I think bytes limitation is good for this. I will update it.

[thinhnx-var]

@zivkovicmilos @petar-dambovaliev
Please take a look on new updated commit. Thank you sir.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 49.93%. Comparing base (5924df8) to head (5350429).

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #2108   +/-   ##
=======================================
  Coverage   49.93%   49.93%           
=======================================
  Files         576      576           
  Lines       77825    77827    +2     
=======================================
+ Hits        38862    38863    +1     
  Misses      35837    35837           
- Partials     3126     3127    +1     

Flag	Coverage Δ
tm2	54.47% <100.00%> (-0.08%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[thinhnx-var]

@moul
I have just done updated the test file as your review.

Old review