Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(examples): rm inexistent dir in make lint targets; use make in ci #2034

Merged
merged 2 commits into from
May 6, 2024

Conversation

n0izn0iz
Copy link
Contributor

@n0izn0iz n0izn0iz commented May 4, 2024

Currently cd examples && make lint fails because gno.land/r/gov does not exists. This PR removes gno.land/r/gov from the targets and refactor the CI to run the make rule

Before

❯ cd examples && make lint
go run ../gnovm/cmd/gno lint ./gno.land/p ./gno.land/r/demo ./gno.land/r/gnoland ./gno.land/r/sys ./gno.land/r/gov
list packages from args: invalid file or package path: stat ./gno.land/r/gov: no such file or directory
exit status 1
make: *** [lint] Error 1

After

❯ cd examples && make lint
go run ../gnovm/cmd/gno lint ./gno.land/p ./gno.land/r/demo ./gno.land/r/gnoland ./gno.land/r/sys
Contributors' checklist...
  • Added new tests, or not needed, or not feasible
  • Provided an example (e.g. screenshot) to aid review or the PR is self-explanatory
  • Updated the official documentation or not needed
  • No breaking changes were made, or a BREAKING CHANGE: xxx message was included in the description
  • Added references to related issues and PRs
  • Provided any useful hints for running manual tests
  • Added new benchmarks to generated graphs, if any. More info here.

@n0izn0iz n0izn0iz requested review from a team as code owners May 4, 2024 10:18
@github-actions github-actions bot added the 🧾 package/realm Tag used for new Realms or Packages. label May 4, 2024
Copy link

codecov bot commented May 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 48.44%. Comparing base (88b9aa3) to head (3cf8518).
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2034   +/-   ##
=======================================
  Coverage   48.44%   48.44%           
=======================================
  Files         409      409           
  Lines       61967    61967           
=======================================
  Hits        30019    30019           
  Misses      29448    29448           
  Partials     2500     2500           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

examples/Makefile Show resolved Hide resolved
Signed-off-by: Norman Meier <[email protected]>
@n0izn0iz n0izn0iz changed the title fix(examples): remove inexistent dir in make lint targets fix(examples): remove inexistent dir in make lint targets and add CI check May 6, 2024
@n0izn0iz n0izn0iz changed the title fix(examples): remove inexistent dir in make lint targets and add CI check fix(examples): rm inexistent dir in make lint targets and add CI check May 6, 2024
@thehowl thehowl changed the title fix(examples): rm inexistent dir in make lint targets and add CI check chore(examples): rm inexistent dir in make lint targets; use make in ci May 6, 2024
@thehowl thehowl merged commit 4809582 into gnolang:master May 6, 2024
201 of 203 checks passed
@n0izn0iz n0izn0iz deleted the fix-example-lint branch May 6, 2024 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🧾 package/realm Tag used for new Realms or Packages.
Projects
Status: Done
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants