feat(stdlibs/errors): support Is function
#1929
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1929 +/- ##
==========================================
- Coverage 47.74% 45.96% -1.79%
==========================================
Files 393 483 +90
Lines 61629 69533 +7904
==========================================
+ Hits 29424 31959 +2535
- Misses 29734 34927 +5193
- Partials 2471 2647 +176 ☔ View full report in Codecov by Sentry. |
notJoon
changed the title
Is function in the errors package
harry-hov
changed the title
Is function in the errors packageIs function
| for { | ||
| if err == target { | ||
| return true | ||
| } | ||
|
|
||
| if x, ok := err.(interface{ Is(error) bool }); ok && x.Is(target) { | ||
| return true | ||
| } | ||
|
|
||
| if x, ok := err.(*errorString); ok { | ||
| if t, ok := target.(*errorString); ok && x.s == t.s { | ||
| return true | ||
| } | ||
| } | ||
|
|
||
| if err = Unwrap(err); err == nil { | ||
| return false | ||
| } | ||
| } |
There was a problem hiding this comment.
I'm worried about edge cases here. Can it go infinite?
There was a problem hiding this comment.
I think an infinity loop will be caused when trying to unwrap the circular referenced errors. this can be prevented by just tracing whether the error has been visited or not.
| return e.msg == t.msg | ||
| } | ||
|
|
||
| func TestIs(t *testing.T) { |
There was a problem hiding this comment.
can we have same set of tests as errors/wrap.go:L16-69?
harry-hov
dismissed
their stale review
should be approved by someone with better understanding
Co-authored-by: Hariom Verma <[email protected]>
|
For this code to fully work, the interface type of https://go.dev/play/p/XUDNrojJ2jh gno/gnovm/pkg/gnolang/gonative.go Lines 862 to 870 in b2f12a9 |
|
This PR is stale because it has been open 3 months with no activity. Remove stale label or comment or this will be closed in 3 months. |
Description
Added the
Isfunction to theerrorspackage.errorStringtypeUnwrapmethod to traverse the error chain to find an error that matches the target error.Relative Issue
#486 // Failed to implement
Asfunction due to the technical issue. maybe later