-
Notifications
You must be signed in to change notification settings - Fork 383
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(gnovm): rename precompiler to transpiler, move to own package #1681
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thehowl
requested review from
jaekwon,
moul,
harry-hov,
piux2 and
a team
as code owners
February 22, 2024 13:18
3 tasks
github-actions
bot
added
🧾 package/realm
Tag used for new Realms or Packages.
📦 🤖 gnovm
Issues or PRs gnovm related
📦 ⛰️ gno.land
Issues or PRs gno.land package related
labels
Feb 22, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1681 +/- ##
==========================================
- Coverage 47.48% 47.47% -0.02%
==========================================
Files 385 385
Lines 61406 61379 -27
==========================================
- Hits 29159 29140 -19
+ Misses 29810 29804 -6
+ Partials 2437 2435 -2 ☔ View full report in Codecov by Sentry. |
…no into dev/morgan/precompile-refactor
ajnavarro
approved these changes
Feb 27, 2024
deelawn
approved these changes
Feb 27, 2024
leohhhn
approved these changes
Feb 28, 2024
leohhhn
pushed a commit
to leohhhn/gno
that referenced
this pull request
Feb 29, 2024
gnolang#1681) Part 1 of several _transpiler_ refactors I intend to perform. This PR tackles one of the first pet peeves I have about the `precompile` tool, which is that the name is not intuitive to what it does. Transpile is a name that not everyone likes. Ultimately, converting one source code to another is also an act of "compilation"; in fact, the TypeScript tool that converts it into JavaScript is called the "TypeScript Compiler". The distinction between transpiler and compiler is blurry; but I think it is useful to call what we have as a _transpiler_ to outline that it is doing a "source-to-source" translation, which I don't think a name like `compile` or `precompile` could. Additionally, this PR moves the source files for the transpiler into its own package, gnovm/pkg/transpiler. One question is to whether the "constants" of the precompiler, like `GnoRealmPkgsPrefixBefore`, should deserve their own package or not.
tbruyelle
added a commit
to tbruyelle/gnols
that referenced
this pull request
Mar 3, 2024
Related change: gnolang/gno#1681
tbruyelle
added a commit
to tbruyelle/gno
that referenced
this pull request
Mar 3, 2024
Related to gnolang#1681 Gnols has been updated to reflect the command rename `precompile` to `transpile`. The configuration options have been renamed accordingly. Related commit: tbruyelle/gnols@2328330
tbruyelle
added a commit
to tbruyelle/gno
that referenced
this pull request
Mar 3, 2024
Related to gnolang#1681 Gnols has been updated to reflect the command rename `precompile` to `transpile`. The configuration options have been renamed accordingly. Related commit: tbruyelle/gnols@2328330
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
📦 ⛰️ gno.land
Issues or PRs gno.land package related
📦 🤖 gnovm
Issues or PRs gnovm related
🧾 package/realm
Tag used for new Realms or Packages.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part 1 of several transpiler refactors I intend to perform.
This PR tackles one of the first pet peeves I have about the
precompile
tool, which is that the name is not intuitive to what it does.Transpile is a name that not everyone likes. Ultimately, converting one source code to another is also an act of "compilation"; in fact, the TypeScript tool that converts it into JavaScript is called the "TypeScript Compiler". The distinction between transpiler and compiler is blurry; but I think it is useful to call what we have as a transpiler to outline that it is doing a "source-to-source" translation, which I don't think a name like
compile
orprecompile
could.Additionally, this PR moves the source files for the transpiler into its own package, gnovm/pkg/transpiler.
One question is to whether the "constants" of the precompiler, like
GnoRealmPkgsPrefixBefore
, should deserve their own package or not.