chore(CODEOWNERS): prefix directories with root slash #1573
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moul
approved these changes
Jan 23, 2024
ajnavarro
approved these changes
Jan 23, 2024
leohhhn
pushed a commit
to leohhhn/gno
that referenced
this pull request
Jan 31, 2024
Pull request gnolang#1572 marks the codeowner as @moul, in spite of what the configuration might suggest to a human reader. [Reading through GitHub's docs](https://docs.github.com/en/repositories/managing-your-repositorys-settings-and-features/customizing-your-repository/about-code-owners#example-of-a-codeowners-file), this seems to come from the fact that if directories are not prefixed with a `/`, they are considered as applying to all files or directories with that name. (ie. `foo` matches `/foo` but also `/src/foo`). I've added `/` to all directories in CODEOWNERS to fix this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request #1572 marks the codeowner as @moul, in spite of what the configuration might suggest to a human reader.
Reading through GitHub's docs, this seems to come from the fact that if directories are not prefixed with a
/, they are considered as applying to all files or directories with that name. (ie.foomatches/foobut also/src/foo).I've added
/to all directories in CODEOWNERS to fix this.