-
Notifications
You must be signed in to change notification settings - Fork 384
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: remove deprecated io/ioutil methods #1277
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #1277 +/- ##
==========================================
+ Coverage 47.87% 55.78% +7.90%
==========================================
Files 372 421 +49
Lines 62990 66124 +3134
==========================================
+ Hits 30158 36885 +6727
+ Misses 30371 26360 -4011
- Partials 2461 2879 +418
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good 👍
there's more ioutil calls throughout the codebase. I think we should also remove the io/ioutil
in Gno's stdlibs.
do you want to tackle this here or in a separate PR?
thanks!
Thanks! I think it would be better to tackle them in here. |
good job on the PR! I saw that you removed basically all calls to thanks! |
this looks good, I asked for another review just to be sure but we should be good to go. |
## Description Replace depreacated `io/ioutil` to `os` methods --------- Co-authored-by: Manfred Touron <[email protected]> Co-authored-by: Morgan Bazalgette <[email protected]>
Description
Replace depreacated
io/ioutil
toos
methods