-
Notifications
You must be signed in to change notification settings - Fork 384
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add hash #1273
feat: add hash #1273
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1273 +/- ##
==========================================
- Coverage 47.86% 47.82% -0.05%
==========================================
Files 372 372
Lines 62990 62990
==========================================
- Hits 30152 30122 -30
- Misses 30383 30404 +21
- Partials 2455 2464 +9 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
||
import ( | ||
"bytes" | ||
"crypto/md5" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not directly related to this particular pull request, but if I remember correctly, we had discussed completely prohibiting this import at some stage.
cc @jaekwon
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's okay actualy.
<!-- please provide a detailed description of the changes made in this pull request. --> Add hash stdlib (especially adler32) and add encoding for dependency ## relate issue gnolang#1267
<!-- please provide a detailed description of the changes made in this pull request. --> Add hash stdlib (especially adler32) and add encoding for dependency ## relate issue gnolang#1267
Add hash stdlib (especially adler32) and add encoding for dependency
relate issue
#1267