Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add hash #1273

Merged
merged 3 commits into from
Oct 25, 2023
Merged

feat: add hash #1273

merged 3 commits into from
Oct 25, 2023

Conversation

notJoon
Copy link
Member

@notJoon notJoon commented Oct 21, 2023

Add hash stdlib (especially adler32) and add encoding for dependency

relate issue

#1267

@notJoon notJoon requested review from jaekwon and moul as code owners October 21, 2023 13:11
@github-actions github-actions bot added the 📦 🤖 gnovm Issues or PRs gnovm related label Oct 21, 2023
@codecov
Copy link

codecov bot commented Oct 21, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f6d500a) 47.86% compared to head (630872c) 47.82%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1273      +/-   ##
==========================================
- Coverage   47.86%   47.82%   -0.05%     
==========================================
  Files         372      372              
  Lines       62990    62990              
==========================================
- Hits        30152    30122      -30     
- Misses      30383    30404      +21     
- Partials     2455     2464       +9     

see 6 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@notJoon notJoon requested a review from a team as a code owner October 21, 2023 14:00
Copy link
Member

@moul moul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM


import (
"bytes"
"crypto/md5"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not directly related to this particular pull request, but if I remember correctly, we had discussed completely prohibiting this import at some stage.

cc @jaekwon

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's okay actualy.

@moul moul merged commit f872ca7 into gnolang:master Oct 25, 2023
182 checks passed
@notJoon notJoon deleted the feat-hash branch October 26, 2023 01:02
gfanton pushed a commit to gfanton/gno that referenced this pull request Nov 9, 2023
<!-- please provide a detailed description of the changes made in this
pull request. -->

Add hash stdlib (especially adler32) and add encoding for dependency

## relate issue

gnolang#1267
moul pushed a commit to moul/gno that referenced this pull request Nov 14, 2023
<!-- please provide a detailed description of the changes made in this
pull request. -->

Add hash stdlib (especially adler32) and add encoding for dependency

## relate issue

gnolang#1267
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📦 🤖 gnovm Issues or PRs gnovm related
Projects
Status: 🚀 Needed for Launch
Status: Done
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants