Skip to content

Commit

Permalink
chore(cmd/gnoland): disable --flag-config-path (#2991)
Browse files Browse the repository at this point in the history 
Not sure about this one. Is anyone using it?

Signed-off-by: moul <[email protected]>
Co-authored-by: Morgan <[email protected]>
  • Loading branch information
@moul @thehowl
moul and thehowl authored Oct 21, 2024
1 parent 24f0a0d commit 6fafe0e
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 17 deletions.
10 changes: 1 addition & 9 deletions gno.land/cmd/gnoland/root.go
View file
Original file line number Diff line number Diff line change
Expand Up @@ -5,12 +5,8 @@ import (
"os"

"github.com/gnolang/gno/tm2/pkg/commands"
"github.com/peterbourgon/ff/v3"
"github.com/peterbourgon/ff/v3/fftoml"
)

const flagConfigFlag = "flag-config-path"

func main() {
cmd := newRootCmd(commands.NewDefaultIO())

Expand All @@ -21,11 +17,7 @@ func newRootCmd(io commands.IO) *commands.Command {
cmd := commands.NewCommand(
commands.Metadata{
ShortUsage: "<subcommand> [flags] [<arg>...]",
ShortHelp: "starts the gnoland blockchain node",
Options: []ff.Option{
ff.WithConfigFileFlag(flagConfigFlag),
ff.WithConfigFileParser(fftoml.Parser),
},
ShortHelp: "manages the gnoland blockchain node",
},
commands.NewEmptyConfig(),
commands.HelpExec,
Expand Down
8 changes: 0 additions & 8 deletions gno.land/cmd/gnoland/start.go
View file
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,6 @@ type startCfg struct {
genesisFile string
chainID string
dataDir string
config string
lazyInit bool

logLevel string
Expand Down Expand Up @@ -136,13 +135,6 @@ func (c *startCfg) RegisterFlags(fs *flag.FlagSet) {
"replacement for '%%REMOTE%%' in genesis",
)

fs.StringVar(
&c.config,
flagConfigFlag,
"",
"the flag config file (optional)",
)

fs.StringVar(
&c.logLevel,
"log-level",
Expand Down

1 comment on commit 6fafe0e

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark 'Go Benchmarks'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.20.

Benchmark suite Current: 6fafe0e Previous: 24f0a0d Ratio
BenchmarkBinary/EmptyStruct:encode 471.4 ns/op 96 B/op 2 allocs/op 292.7 ns/op 96 B/op 2 allocs/op 1.61
BenchmarkBinary/EmptyStruct:encode - ns/op 471.4 ns/op 292.7 ns/op 1.61
BenchmarkBinary/EmptyStruct:decode 258.4 ns/op 0 B/op 0 allocs/op 142 ns/op 0 B/op 0 allocs/op 1.82
BenchmarkBinary/EmptyStruct:decode - ns/op 258.4 ns/op 142 ns/op 1.82
BenchmarkBinary/ShortArraysStruct:encode 793.4 ns/op 192 B/op 4 allocs/op 615.6 ns/op 192 B/op 4 allocs/op 1.29
BenchmarkBinary/ShortArraysStruct:encode - ns/op 793.4 ns/op 615.6 ns/op 1.29
BenchmarkBinary/ShortArraysStruct:decode 384.7 ns/op 0 B/op 0 allocs/op 232.6 ns/op 0 B/op 0 allocs/op 1.65
BenchmarkBinary/ShortArraysStruct:decode - ns/op 384.7 ns/op 232.6 ns/op 1.65
BenchmarkDetaching 126.7 ns/op 0 B/op 0 allocs/op 91.23 ns/op 0 B/op 0 allocs/op 1.39
BenchmarkDetaching - ns/op 126.7 ns/op 91.23 ns/op 1.39
BenchmarkBcryptGenerateFromPassword/benchmark-security-param 63784356 ns/op 5130 B/op 9 allocs/op 31931651 ns/op 5125 B/op 9 allocs/op 2.00
BenchmarkBcryptGenerateFromPassword/benchmark-security-param - ns/op 63784356 ns/op 31931651 ns/op 2.00
BenchmarkBcryptGenerateFromPassword/benchmark-security-param 127491133 ns/op 5139 B/op 9 allocs/op 31931651 ns/op 5125 B/op 9 allocs/op 3.99
BenchmarkBcryptGenerateFromPassword/benchmark-security-param - ns/op 127491133 ns/op 31931651 ns/op 3.99
BenchmarkBcryptGenerateFromPassword/benchmark-security-param 254996965 ns/op 5158 B/op 9 allocs/op 31931651 ns/op 5125 B/op 9 allocs/op 7.99
BenchmarkBcryptGenerateFromPassword/benchmark-security-param - ns/op 254996965 ns/op 31931651 ns/op 7.99
BenchmarkBcryptGenerateFromPassword/benchmark-security-param 509867193 ns/op 5196 B/op 10 allocs/op 31931651 ns/op 5125 B/op 9 allocs/op 15.97
BenchmarkBcryptGenerateFromPassword/benchmark-security-param - ns/op 509867193 ns/op 31931651 ns/op 15.97
BenchmarkBcryptGenerateFromPassword/benchmark-security-param 1019699255 ns/op 5736 B/op 15 allocs/op 31931651 ns/op 5125 B/op 9 allocs/op 31.93
BenchmarkBcryptGenerateFromPassword/benchmark-security-param - ns/op 1019699255 ns/op 31931651 ns/op 31.93
BenchmarkBcryptGenerateFromPassword/benchmark-security-param - allocs/op 15 allocs/op 9 allocs/op 1.67
BenchmarkBcryptGenerateFromPassword/benchmark-security-param 2039132903 ns/op 5736 B/op 15 allocs/op 31931651 ns/op 5125 B/op 9 allocs/op 63.86
BenchmarkBcryptGenerateFromPassword/benchmark-security-param - ns/op 2039132903 ns/op 31931651 ns/op 63.86
BenchmarkBcryptGenerateFromPassword/benchmark-security-param - allocs/op 15 allocs/op 9 allocs/op 1.67
BenchmarkSigning 84229 ns/op 1856 B/op 36 allocs/op 25694 ns/op 64 B/op 1 allocs/op 3.28
BenchmarkSigning - ns/op 84229 ns/op 25694 ns/op 3.28
BenchmarkSigning - B/op 1856 B/op 64 B/op 29
BenchmarkSigning - allocs/op 36 allocs/op 1 allocs/op 36
BenchmarkSigning 82857 ns/op 1856 B/op 36 allocs/op 25694 ns/op 64 B/op 1 allocs/op 3.22
BenchmarkSigning - ns/op 82857 ns/op 25694 ns/op 3.22
BenchmarkSigning - B/op 1856 B/op 64 B/op 29
BenchmarkSigning - allocs/op 36 allocs/op 1 allocs/op 36
BenchmarkVerification 164167 ns/op 864 B/op 19 allocs/op 61409 ns/op 0 B/op 0 allocs/op 2.67
BenchmarkVerification - ns/op 164167 ns/op 61409 ns/op 2.67
BenchmarkVerification - B/op 864 B/op 0 B/op +∞
BenchmarkVerification - allocs/op 19 allocs/op 0 allocs/op +∞
BenchmarkVerification 169409 ns/op 864 B/op 19 allocs/op 61409 ns/op 0 B/op 0 allocs/op 2.76
BenchmarkVerification - ns/op 169409 ns/op 61409 ns/op 2.76
BenchmarkVerification - B/op 864 B/op 0 B/op +∞
BenchmarkVerification - allocs/op 19 allocs/op 0 allocs/op +∞
BenchmarkRandomBytes/random 69.01 ns/op 16 B/op 1 allocs/op 32.67 ns/op 4 B/op 1 allocs/op 2.11
BenchmarkRandomBytes/random - ns/op 69.01 ns/op 32.67 ns/op 2.11
BenchmarkRandomBytes/random - B/op 16 B/op 4 B/op 4
BenchmarkRandomBytes/random 105 ns/op 32 B/op 1 allocs/op 32.67 ns/op 4 B/op 1 allocs/op 3.21
BenchmarkRandomBytes/random - ns/op 105 ns/op 32.67 ns/op 3.21
BenchmarkRandomBytes/random - B/op 32 B/op 4 B/op 8
BenchmarkRandomBytes/random 269.6 ns/op 112 B/op 1 allocs/op 32.67 ns/op 4 B/op 1 allocs/op 8.25
BenchmarkRandomBytes/random - ns/op 269.6 ns/op 32.67 ns/op 8.25
BenchmarkRandomBytes/random - B/op 112 B/op 4 B/op 28
BenchmarkRandomBytes/random 2321 ns/op 1024 B/op 1 allocs/op 32.67 ns/op 4 B/op 1 allocs/op 71.04
BenchmarkRandomBytes/random - ns/op 2321 ns/op 32.67 ns/op 71.04
BenchmarkRandomBytes/random - B/op 1024 B/op 4 B/op 256
BenchmarkSmall/boltdb-1000-100-16-40/update 1472824 ns/op 44439 B/op 394 allocs/op 951074 ns/op 37570 B/op 370 allocs/op 1.55
BenchmarkSmall/boltdb-1000-100-16-40/update - ns/op 1472824 ns/op 951074 ns/op 1.55
BenchmarkSmall/memdb-1000-100-16-40/block 15558401 ns/op 9269566 B/op 169121 allocs/op 11919576 ns/op 6563792 B/op 116469 allocs/op 1.31
BenchmarkSmall/memdb-1000-100-16-40/block - ns/op 15558401 ns/op 11919576 ns/op 1.31
BenchmarkSmall/memdb-1000-100-16-40/block - B/op 9269566 B/op 6563792 B/op 1.41
BenchmarkSmall/memdb-1000-100-16-40/block - allocs/op 169121 allocs/op 116469 allocs/op 1.45
BenchmarkMedium/boltdb-100000-100-16-40/update 6874278 ns/op 135734 B/op 1060 allocs/op 5551087 ns/op 102784 B/op 869 allocs/op 1.24
BenchmarkMedium/boltdb-100000-100-16-40/update - ns/op 6874278 ns/op 5551087 ns/op 1.24
BenchmarkMedium/boltdb-100000-100-16-40/update - B/op 135734 B/op 102784 B/op 1.32
BenchmarkMedium/boltdb-100000-100-16-40/update - allocs/op 1060 allocs/op 869 allocs/op 1.22
BenchmarkMedium/memdb-100000-100-16-40/update 1212632 ns/op 368041 B/op 7293 allocs/op 980160 ns/op 255920 B/op 4941 allocs/op 1.24
BenchmarkMedium/memdb-100000-100-16-40/update - ns/op 1212632 ns/op 980160 ns/op 1.24
BenchmarkMedium/memdb-100000-100-16-40/update - B/op 368041 B/op 255920 B/op 1.44
BenchmarkMedium/memdb-100000-100-16-40/update - allocs/op 7293 allocs/op 4941 allocs/op 1.48
BenchmarkLevelDBBatchSizes/goleveldb-100000-400-16-40/update - B/op 47955 B/op 39178 B/op 1.22
BenchmarkLevelDBBatchSizes/goleveldb-100000-400-16-40/update - allocs/op 584 allocs/op 459 allocs/op 1.27
BenchmarkHash/ripemd160 2963 ns/op 25 B/op 1 allocs/op 697.9 ns/op 25 B/op 1 allocs/op 4.25
BenchmarkHash/ripemd160 - ns/op 2963 ns/op 697.9 ns/op 4.25
BenchmarkHash/sha2-256 521.7 ns/op 33 B/op 1 allocs/op 168.4 ns/op 33 B/op 1 allocs/op 3.10
BenchmarkHash/sha2-256 - ns/op 521.7 ns/op 168.4 ns/op 3.10
BenchmarkHash/sha3-256 1838 ns/op 33 B/op 1 allocs/op 716.3 ns/op 33 B/op 1 allocs/op 2.57
BenchmarkHash/sha3-256 - ns/op 1838 ns/op 716.3 ns/op 2.57
BenchmarkWriteSecretConnection 6389 ns/op 0 B/op 0 allocs/op 4026 ns/op 0 B/op 0 allocs/op 1.59
BenchmarkWriteSecretConnection - ns/op 6389 ns/op 4026 ns/op 1.59
BenchmarkReadSecretConnection 3492 ns/op 0 B/op 0 allocs/op 2360 ns/op 0 B/op 0 allocs/op 1.48
BenchmarkReadSecretConnection - ns/op 3492 ns/op 2360 ns/op 1.48

This comment was automatically generated by workflow using github-action-benchmark.

CC: @ajnavarro @thehowl @zivkovicmilos

Please sign in to comment.