redis: use a Lua script to get measures #730
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tests SUCCESS for HEAD 320a487
|
chungg
reviewed
Feb 8, 2018
| raise storage.AggregationDoesNotExist( | ||
| metric, aggregation, sampling) | ||
| if code == -2: | ||
| raise storage.MetricDoesNotExist(metric) |
There was a problem hiding this comment.
i don't think we have tests for this as i deleted the following and it still passes.
+ if code == -1:
+ sampling = utils.to_timespan(result.split(self.FIELD_SEP_B)[2])
+ raise storage.AggregationDoesNotExist(
+ metric, aggregation, sampling)
+ if code == -2:
+ raise storage.MetricDoesNotExist(metric)
tbh, i'm not sure it's possible to get this far as we do validate the aggregation beforehand.
There was a problem hiding this comment.
I just kept the same structure, so IIUC, this is not a new problem (if it is one at all)?
There was a problem hiding this comment.
well it's a problem in that the errors raise are never validated so in theory, you could've broken it :P
sileht
approved these changes
Feb 9, 2018
|
Tests SUCCESS for HEAD 16bf7bc
|
ghost
merged commit
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.