Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Function call issue for parsing sentinel_fallback (backport #1405) #1407

Merged
merged 1 commit into from
Sep 2, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Sep 2, 2024

Hi,
The _parse_sentinel was a class function and when it get called by

sentinel_hosts = [
            _parse_sentinel(fallback)
            for fallback in kwargs.pop('sentinel_fallback', [])
        ]

It made errors because it doesn't pass cls to it and it can't receive the sentinel.
So I made it static and tested it and its OK now.


This is an automatic backport of pull request #1405 done by Mergify.

@tobias-urdin tobias-urdin merged commit 5f26d4f into stable/4.6 Sep 2, 2024
23 of 25 checks passed
@mergify mergify bot deleted the mergify/bp/stable/4.6/pr-1405 branch September 2, 2024 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants